Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032856AbbKEHWu (ORCPT ); Thu, 5 Nov 2015 02:22:50 -0500 Received: from mail-bn1bon0085.outbound.protection.outlook.com ([157.56.111.85]:38414 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1032392AbbKEHVh (ORCPT ); Thu, 5 Nov 2015 02:21:37 -0500 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; linuxfoundation.org; dkim=none (message not signed) header.d=none;linuxfoundation.org; dmarc=bestguesspass action=none header.from=xilinx.com; From: Soren Brinkmann To: Greg Kroah-Hartman , Jiri Slaby CC: Michal Simek , , , , "Soren Brinkmann" Subject: [PATCH v2 06/10] tty: xuartps: Keep lock for whole ISR Date: Wed, 4 Nov 2015 23:21:15 -0800 Message-ID: <1446708079-1105-7-git-send-email-soren.brinkmann@xilinx.com> X-Mailer: git-send-email 2.6.2.3.ga463a5b In-Reply-To: <1446708079-1105-1-git-send-email-soren.brinkmann@xilinx.com> References: <1446708079-1105-1-git-send-email-soren.brinkmann@xilinx.com> X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21920.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD011;1:uvuTrJXxz3+0yKHy51ScrNrgrIdKWQxs0oPK1O70T61MC9yhEOdqKwFGrvLiFC/n40snwOiZtZTIAgr0mle6qkUNoCcPkVALwUDXl2tpLqNFshtM+oCMaie3W1/QMhN9B9jqHpbwUtafTeeai3oqW1kCXwSOOLfecI0czqTZclbA296NmTqDgZeVdeJUkfC29UfCtroL/mcUdXHgTFdbTghgpTzSolTYALJ43Ml1jRrofszM2vNma/T4q0m95xCjPGGE5vR6XTD9VIZfC4J6VcAiKOBvcJXcDrvZpdbuvWAmtJaMbyQF/V9eurvtCYG/QOcFpoMnkR671usauNvZhmOD/cRwPjIlipXcSZ0EGJ4= X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(199003)(189002)(19580395003)(5007970100001)(5001920100001)(11100500001)(106466001)(36386004)(5008740100001)(36756003)(229853001)(87936001)(5001770100001)(86362001)(50226001)(81156007)(5003940100001)(6806005)(575784001)(50986999)(4001430100002)(48376002)(107886002)(33646002)(63266004)(189998001)(57986006)(92566002)(76506005)(16796002)(76176999)(5001960100002)(77096005)(19580405001)(47776003)(50466002)(2950100001)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2FFO11HUB046;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB046;2:bKqknFy1f6QJMHMQLZuqpSMwfNVoNLMkoqzEQ1cWh6QK54ZCxtTRF189/Df09C8dgYaw2zKWwGxzH7hZfkAa8+WqkpvsignHONp2kz+7cWdq1XulMmBppD+Xzo5B8op7DyxcE2XGHTeuOLsy0PN0THzT1neMBYNd8GVSRr2GYb4=;3:x5MjoBs9m3DDPscK5kJCX/obS/HSLr0OFes4Rkmmhw77ebnrMVEZQsQ3k0FF1VsomHvVZJRszYnms6k+T8Q5PzdxigAWWTtHLumxFX1vHGb1xM8Uw/qLviQ705cXQMRex8WUtR0YAvqNUwza50ndSp625XVYy/vyW4oIJd+FFRT0DtefR8JdiqGJWPq+Uym/ITXhXPJPtcgkGv7jtkwkV3Tk1IlV4AB0ssSEm4Lt6c6Nxb20zYqDvc87+gFocvohk6NoW5l72Y68zELXBwsWQw==;25:fCx+ozTF9zIxvDAfs67sPGZ7WzvzxQ3IpDaQBxVvKWBvClTOojqQJkFSOHsqsxJVPyEomSGo/EoVg4Yf2ZfL2NdSisB599eKm806cmURO4mpAUOrfg0vP95jOsNG3DT5N/z8MdwXiYyFpa8C6Sxf4C9E/d15tzdT/mvn/65YTOU+96RY4Ju4YZ7Y4rqZmMr17pg0maTXMD00I90ycOGM77YTYSmHecD+YnbmLwQ1pcigwG7TacbGUXYsUoAOy+/hhoYl0xEhXuJPn1vZ3MgmZg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BL2FFO11HUB046; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB046;20:ykAg1Vr+NTHsMAs5X9zgjO6+mBZa9GXOn4VWGf/55lf4g7gyq/g58yUIshyvtLLyMRbI9spGTS1jOGHXn6aH77H+yaphz+9I4d4dW3bRMvVE66L3I1t9tHP5wQEs00VgxETuE5yq0NEvzpF8rfvfb4dXJ6vQcWkPP8ieYeiK4XmnNsJnbnA8gOMSEC1EZ1Ezs+TE7rZ9bZAU3B4jz/y5fa5q3UIjrTyiKa8wd6GaXCyRlaRCgld9B7KAZI6Bn0JUxRcrcSU49KUHNb1SD7FpbKfp4wsYv2gFV7EEyDiTs7q+ySfNBa5IXnQbLV3HeVV5Uf0U+hNvgA4EMqFLMQV8l50wDcm5VSLnEVo98gxPpy56eccoZYEMyOjb9u+stSvWn65c+feVF+U7iPh9n6CTN0pywj+/+p0Jcp9pp7v4Yxv+692+OGFqGXj8opFCUpfy/PDrQfHbTulf961IjWpi7VSYMzNErX1tmeSj6rNrZ7IFs2zwfLRKyDYwkNE3pU9d;4:JzICkRMxz7vPO47YkhXV+ZaCElixQPYxGopjQLqe6uTw3R8C53KF398wPA1nVnKeha6CJ71OBIYnU0CAgKv5SffVhgVBfVrSXIX8p14mnD9h5JchE3toyjSVNNbWjMaAc5ehTYfesyO5fpx7unQs6FeK1ekUuxZuYZkDqsiM0WKYFqVhPfnyYS1Anre93SSbenln4Vb9hykFV4GDRBsZCE3oZAXAernIStifeMkKHX6uqUK/WNGMfllAyCaG7mA7DOHm7TnfFVK+s91OBTABmMqMNsyO86LYhSYR2dfKGO08bDflMYJNIrbbgpKfoyXTqLYTl+bW8Ex9pU0FT1478Pbk2a+a8nORuPnH1EtY6AWltRs7vb5xWlKzbZTadGNk X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(520078)(5005006)(10201501046)(3002001);SRVR:BL2FFO11HUB046;BCL:0;PCL:0;RULEID:;SRVR:BL2FFO11HUB046; X-Forefront-PRVS: 0751474A44 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2FFO11HUB046;23:3RImCMWmrmUtBzXeb0lZW6HkPr++DsZ+pZgPhJ6u?= =?us-ascii?Q?w//EeDgOsng3TLLmqqAtryj77sRG3zrWjEk9pw6UrBY2ufXOse4tepGFsK3c?= =?us-ascii?Q?fxmFD3A1ldrkFjbSpARJFRetwd9vUvfSmyNuoh6Bdb+cGr7NvL5qbn1dS5HN?= =?us-ascii?Q?aJhdaUoSrlJ+/vRahgUMlqJ/P7cCo+c2nw8yE0dFfsKgnnDD+cxZ8aOF+pNZ?= =?us-ascii?Q?85g76I/wfyhayeNIiXM9g2wxrgnKNS7bPItcSrdaN1QtaOgPCqjTXHrP7qhr?= =?us-ascii?Q?TIK58Nf/qbKj9byhZwKUbiUB53blbrjXxiUasLkFsQM/PyK3WGtYgfG7rYwy?= =?us-ascii?Q?mYQcb9McN+DcecEJOUxE323ontb15LFviBSyOom4YYQuvRAcUYKoW8OY4tGA?= =?us-ascii?Q?JAYEfY/lVP+ZF1tFKxEovosrMmOAs2GqK6BjsOhB5dxPX2eLEHm0OK9QKJnm?= =?us-ascii?Q?7SX79B7A7r0FCvEvr6RjY6PB+Vw7h5MoFTs/uHNP4y98ELblmwwOw1OAjxn4?= =?us-ascii?Q?LUzTYwnovkHJ5aV+Dmb6rHiVWuoCHT6g2jGL8Xh3KFDved+c051nB6YQtAq4?= =?us-ascii?Q?qZCXaRksrUusxghtNPUpkVQi/E0V4oJEBc/IMSwHm8b+1IjHL/gGGTDS9780?= =?us-ascii?Q?O5h1Aay/3oqgUiNtiQKzSvtYfonssvlY94ZgahKwZWxm8S3dD+x09LpoQ8EJ?= =?us-ascii?Q?Vze3FNxzI9Pa9oeQhVzyieuGgMDuWiTTej4GGs+3cGDNemnotCKWF+2mfoJn?= =?us-ascii?Q?9ZKUOxf9Kylo/wKeQiCSjtcCJU1ieXfKJgceg6wX9UphCSVX9wj/JIxxG9wA?= =?us-ascii?Q?GMTyNwvFT9kqG9OCyt7bo/Spx0ZYLuAAxxXs7revZmeMfc4Z3vfwPa20tLjK?= =?us-ascii?Q?/f6lZEAnLdYsN13Gmlu0XankMg+ry4WdavXshu+Gq4sw7P/qWPN1djZD/hkM?= =?us-ascii?Q?kgL/ELgG5QJi9WQfSixcdZJ+yjOM+UtBgTkqQq4VdP3oh/r1JigrGiQx/yqL?= =?us-ascii?Q?BkXnhQoio9bbxrdI30UyZTBdfg51QpPxppx7ih57fBrkuA36TPWv3lgqZHmn?= =?us-ascii?Q?bO3miLi7C0hZoPmtGWYUSJAmxg0nLClsIgpQZ0ZjWSoW4c6SQsnWeY2NUOZH?= =?us-ascii?Q?iXE2YllhGCj8LTtQ6n8tEf+ekqUXi2Om?= X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11HUB046;5:Y+rregCfECOy7fXSqdewWgLUQ9wYSr52trXUmY3qv2gWBagGUtdaciyMUW+hI/CJbGC0q5If49eZvVh/ISFK+/d2p+mG/G5RfbXErgOyp/04yz7bFXU2iGNAbw/ie+Vhga0W8kcFbylaoIOeoF+emg==;24:euksH2A1llDBGlEhgPeLkgY3wKnaOGv7LILrRnzkubGwRx321HycOUzJ6kd/jK4+9So6c1vDzepHO8xoSy3fkcaTLU4TK5s2fpWwxcilU/c= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Nov 2015 07:21:35.4425 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2FFO11HUB046 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 993 Lines: 29 The RX path in the interrupt handler released a lock unnecessarily. Signed-off-by: Soren Brinkmann --- drivers/tty/serial/xilinx_uartps.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 167e0f4bcf7a..5efd1b9d220f 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -265,9 +265,7 @@ static irqreturn_t cdns_uart_isr(int irq, void *dev_id) uart_insert_char(port, isrstatus, CDNS_UART_IXR_OVERRUN, data, status); } - spin_unlock(&port->lock); tty_flip_buffer_push(&port->state->port); - spin_lock(&port->lock); } /* Dispatch an appropriate handler */ -- 2.6.2.3.ga463a5b -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/