Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032014AbbKEKdH (ORCPT ); Thu, 5 Nov 2015 05:33:07 -0500 Received: from mail-yk0-f174.google.com ([209.85.160.174]:34367 "EHLO mail-yk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031089AbbKEKdF (ORCPT ); Thu, 5 Nov 2015 05:33:05 -0500 MIME-Version: 1.0 In-Reply-To: References: <1446702633-14019-1-git-send-email-drinkcat@chromium.org> Date: Thu, 5 Nov 2015 18:33:04 +0800 Message-ID: Subject: Re: [PATCH] spi: mediatek: single device does not require cs_gpios From: Nicolas Boichat To: Andy Shevchenko Cc: Mark Brown , Leilk Liu , Matthias Brugger , linux-spi@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-arm Mailing List , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1032 Lines: 26 On Thu, Nov 5, 2015 at 5:16 PM, Andy Shevchenko wrote: > On Thu, Nov 5, 2015 at 7:50 AM, Nicolas Boichat wrote: [...] >> diff --git a/drivers/spi/spi-mt65xx.c b/drivers/spi/spi-mt65xx.c >> index 563954a..f694031 100644 >> --- a/drivers/spi/spi-mt65xx.c >> +++ b/drivers/spi/spi-mt65xx.c >> @@ -410,7 +410,7 @@ static int mtk_spi_setup(struct spi_device *spi) >> if (!spi->controller_data) >> spi->controller_data = (void *)&mtk_default_chip_info; >> >> - if (mdata->dev_comp->need_pad_sel) >> + if (mdata->dev_comp->need_pad_sel && spi->cs_gpio >= 0) > > gpio_is_valid() ? Yes, thanks! Will fix in next round. (there is a few other ones in driver/spi/* that should probably be fixed too...) Best, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/