Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032309AbbKELgm (ORCPT ); Thu, 5 Nov 2015 06:36:42 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:48829 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031023AbbKELgk (ORCPT ); Thu, 5 Nov 2015 06:36:40 -0500 X-AuditID: cbfec7f4-f79c56d0000012ee-49-563b3f451b27 From: Pavel Fedin To: "'Krzysztof Kozlowski'" , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: k.kozlowski.k@gmail.com, "'Rob Herring'" , "'Pawel Moll'" , "'Mark Rutland'" , "'Ian Campbell'" , "'Kumar Gala'" , "'Kukjin Kim'" References: <4568ad982f0af1846994119961cbb798edff311c.1446542020.git.p.fedin@samsung.com> <5639C1A5.1040708@samsung.com> <004f01d117bb$1e4fbb40$5aef31c0$@samsung.com> <563B3D15.2070700@samsung.com> In-reply-to: <563B3D15.2070700@samsung.com> Subject: RE: [PATCH v5 4/4] ARM: dts: Add Ethernet chip to SMDK5410 Date: Thu, 05 Nov 2015 14:36:36 +0300 Message-id: <005001d117be$3b5709c0$b2051d40$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQInd0NHxwReN7LBFLXzkPqpXKHCoQHcQWVDAgq4v9kB2I0LZQIg5C9tnaGJw2A= Content-language: ru X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOIsWRmVeSWpSXmKPExsVy+t/xq7qu9tZhBrPu6FvMP3KO1aL/zUJW i3OvVjJaPP/3g93i9QtDi/7Hr5ktNj2+xmpxedccNosZ5/cxWSy9fpHJYsL0tSwWrXuPsDvw eKyZt4bR43JfL5PHzll32T1WLv/C5rFpVSebx+Yl9R59W1YxenzeJBfAEcVlk5Kak1mWWqRv l8CVcfPRLaaCn2wVH986NDAeZe1i5OSQEDCRuPbnHBuELSZx4d56IJuLQ0hgKaPEgwXLoJzv jBKbL3WxgFSxCahLnP76gQUkISKwi1Hi15ZuMIdZoJVJ4u7i3awQLd8YJX6sWsEI0sIpoC3R Mekp2BJhAWeJk70rmEBsFgFVidZJC4BsDg5eAUuJM5vBSngFBCV+TL4Hto1ZQEti/c7jTBC2 vMTmNW+ZIW5VkNhx9jXYeBEBP4nb2y8xQtSISEz7d495AqPQLCSjZiEZNQvJqFlIWhYwsqxi FE0tTS4oTkrPNdQrTswtLs1L10vOz93ECIm+LzsYFx+zOsQowMGoxMNrUG0VJsSaWFZcmXuI UYKDWUmEV0rWOkyINyWxsiq1KD++qDQntfgQozQHi5I479xd70OEBNITS1KzU1MLUotgskwc nFINjO28Sz33qYYsTDq3OG6pyrrDKkyMlzPOr1v/VveX4i2D7V575NR/v75x+IMc/+6VDWVP q6eaFHnsvB94dEdoHmtgZH3tdA1r7TunP7w+JqbsrRljK7jmTVz2b2bHN2IW969uMNF52WM9 ZevmuN/fWWduuvau17p2W9iVz3Olk7/7X/71dPG3qDolluKMREMt5qLiRABoMMJ6ugIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1106 Lines: 34 Hello! > >>> + ethernet@3 { > >>> + compatible = "smsc,lan9115"; > >>> + reg = <3 0 0x10000>; > >>> + phy-mode = "mii"; > >>> + interrupt-parent = <&gpx0>; > >>> + interrupts = <5 8>; > >> > >> s/8/IRQ_TYPE_LEVEL_LOW/ > >> (is this really level low interrupt?) > > > > Yes, according to: https://github.com/AndreiLux/Perseus-S3/blob/master/arch/arm/mach- > exynos/mach-smdk5250.c#L133 > > Although this is different board, but okay. I am curious too, so i examined SMSC datasheet. The IRQ is fully programmable on chip's side too, and our driver indeed defaults to active-low. You can switch it to active-high by addint smsc,irq-active-high property. But i just copied settings from those old Android kernels, and it just works. So, cleaning up and posting v6. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/