Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161459AbbKENlj (ORCPT ); Thu, 5 Nov 2015 08:41:39 -0500 Received: from forward13m.cmail.yandex.net ([5.255.216.144]:57798 "EHLO forward13m.cmail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161237AbbKENlh (ORCPT ); Thu, 5 Nov 2015 08:41:37 -0500 X-Greylist: delayed 460 seconds by postgrey-1.27 at vger.kernel.org; Thu, 05 Nov 2015 08:41:37 EST From: Evgeniy Polyakov Envelope-From: drustafa@yandex.ru To: Jiri Kosina Cc: "linux-kernel@vger.kernel.org" , GregKH In-Reply-To: References: <2428911445956236@web17h.yandex.ru> Subject: Re: [PATCH] w1: w1_process() is not freezable kthread MIME-Version: 1.0 Message-Id: <215991446730430@web4m.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Thu, 05 Nov 2015 16:33:50 +0300 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=koi8-r Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1075 Lines: 26 Hi 28.10.2015, 08:26, "Jiri Kosina" : > On Tue, 27 Oct 2015, Evgeniy Polyakov wrote: > >> ?> w1_process() calls try_to_freeze(), but the thread doesn't mark itself >> ?> freezable through set_freezable(), so the try_to_freeze() call is useless. >> >> ?I believe it is better to mark it freezable, what do you think? Its task >> ?is useless if anyone else goes sleeping, it should freeze too. > > I fail to see why this kthread should be freezable at all. There is no way > for w1 device to generate new I/O requests that should be written out to > filesystem, is it? w1 doesn't generate such requests, but it was more to make this thread consistent with majority of other threads in the kernel. Ok, I'm not against it, Greg please pull this patch into your tree. Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/