Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161669AbbKEOgx (ORCPT ); Thu, 5 Nov 2015 09:36:53 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:40789 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030728AbbKEOgv (ORCPT ); Thu, 5 Nov 2015 09:36:51 -0500 From: Felipe Balbi To: Peter Chen CC: Nathan Sullivan , , , Subject: Re: [PATCH V4] usb: remove unnecessary CONFIG_PM dependency from USB_OTG In-Reply-To: <20151105021319.GA16142@shlinux2> References: <1446126743-31892-1-git-send-email-nathan.sullivan@ni.com> <8737wnnq3c.fsf@saruman.tx.rr.com> <20151104030056.GA20460@shlinux2> <87r3k6mngw.fsf@saruman.tx.rr.com> <20151105021319.GA16142@shlinux2> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Thu, 5 Nov 2015 08:36:41 -0600 Message-ID: <87h9l0343q.fsf@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4922 Lines: 131 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Peter Chen writes: > On Tue, Nov 03, 2015 at 09:51:11PM -0600, Felipe Balbi wrote: >>=20 >> Hi, >>=20 >> Peter Chen writes: >> > On Tue, Nov 03, 2015 at 07:56:55AM -0600, Felipe Balbi wrote: >> >>=20 >> >> Hi, >> >>=20 >> >> Nathan Sullivan writes: >> >> > The USB OTG support currently depends on power management >> >> > (CONFIG_PM) being enabled, but does not actually need it enabled. >> >> > Remove this dependency. >> >> > >> >> > Tested on Bay Trail hardware with dwc3 USB. >> >> > >> >> > Signed-off-by: Nathan Sullivan >> >> > --- >> >> > drivers/usb/core/Kconfig | 1 - >> >> > 1 file changed, 1 deletion(-) >> >> > >> >> > diff --git a/drivers/usb/core/Kconfig b/drivers/usb/core/Kconfig >> >> > index a99c89e..9c5cdf3 100644 >> >> > --- a/drivers/usb/core/Kconfig >> >> > +++ b/drivers/usb/core/Kconfig >> >> > @@ -43,7 +43,6 @@ config USB_DYNAMIC_MINORS >> >> >=20=20 >> >> > config USB_OTG >> >> > bool "OTG support" >> >> > - depends on PM >> >>=20 >> >> I don't think this is correct. OTG depends on USB bus suspend, which = is >> >> only available on PM builds. Care to further detail why you think PM = is >> >> not needed on OTG ? >> >>=20 >> > >> > OTG depends on USB bus suspend is not a must, the hardware controlled = OTG >> > design do HNP when the bus goes to suspend; but if the software >> > implements OTG FSM, it is the user option whether do HNP, and bus >> > suspend is controlled by OTG FSM software (stop SOF), but not by host= =20 >> > stack (eg, ehci). >> > >> > I am sorry I did not consider the legacy OTG design, this patch should >> > be dropped. >>=20 >> there is no "legacy" OTG design. OTG requires a bus suspend to enter >> HNP, and that's achieved by stopping all transfers and avoid new URB >> submission so usbcore can put the bus in suspend (by means of USB >> autosuspend). If you're bypassing that in the OTG FSM thing, that needs >> to be fixed ASAP as that makes it a lot harder for any generic changes >> in usbcore to be validated. Specially when you consider not many will >> have whatever special HW which, likely, doesn't even work with mainline >> to validate a change. >>=20 > > Felipe, thanks for your comments. > > But you may need to consider the user option ~a_bus_req (for A) and > b_bus_req (for B) when do HNP, we can't do HNP without user option. > > - Eg, if the bus enters suspend, but the A does not want role switch, > we can't try to do HNP, the same for B device. > - The A device may want to support auto-suspend but without role switch. > > You are absolutely right, the SAFE HNP needs to do auto-suspend first, we > need to add this in documentation. But it does not mean OTG FSM design is > incorrect, there are two things, eg, if we want to do HNP safely, we > need sure it does. If you're bypassing anything in usbcore, it's wrong :-) For that [ab]_bus_req polling, as soon as you notice that flag, you should just giveback all URBs to the link partner so the link can autosuspend and HNP will happen exactly the same. > to do below things: > /* B requests HNP */ > echo 1 > /sys/bus/../otg_fsm//inputs/b_bus_req=20 > > /* Put the A to suspend */ > echo auto > /sys/bus/usb/devices/1-1/power/control=20 > /* A goes to try HNP */ > echo 0 > /sys/bus/../otg_fsm/inputs/a_bus_req When you echo 0 to a_bus_req, A should stop all in-flight transfers to the link partner and wait for the bus to autosuspend. There should be no differences other than the need to set these flags. This even gives us opportunity to tune "how fast" we wand HNP to happen by fiddling with autosuspend delay ;-) =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWO2l7AAoJEIaOsuA1yqREVocP/jvrBTCxmTnuTamNw0/IXFFc o7KLgfAo9oJJEYk5sLeX2iJwf4E8OKpw9Su/6ow80R0nUWeBcKcGmydqq9vyTEwZ QrtgiYvPM6bLTIrld23HnbKHO2psV8gcY57lPTxdnPRXAszkQw3/6ihgwHsiVeMD ABM+QwE9uhA+vO5FutjNNfhvmmC41fuHj0JXSzlQBRXmV3w7pY4FSTldywglpjS/ Vr1JugK2mvkAof/0NhyjYsYKQOyf38bKlzatN/ZRMb4c17NmWr8nLhA5E+Aix7aC Zav+bBEP8Une0DDv0TUnA+3RNX+vQ825IL15oUKDQpcaFe3VdzzKe6M6pUKb02M0 0TRSu4R0PMNaPt37CAnq4JMMlbhlBAgYJz4nNKjUNGXAhhZgebku31aUAJCDzKEF wg2BkRriCGWbAMFa1XLz6B/c+M+a0uDMBJZbGEBhHRz1AzOHkWZ5Z23pPi4Lv1lk B8aLN3wB5r6SMQxKePfSqggDRVs/1EmOBOzfFrcoJ5T5z4Rpl+C6Eau+zhtpSpBK jycSB1WCUT0n64pTffyo8fhKpdU5rFGUAt88NWCaGjWV/FeNYVS/9RyLMXYhjdU1 JNw+qOYdlLrwmwZ4un2RHFjQPFj9NECiHLg2BFGTIG260N3/RWp9LPoJyGcq1nBL v1frIC0mkRuxGhbzHtZe =5jVu -----END PGP SIGNATURE----- --=-=-=-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/