Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161929AbbKEPWy (ORCPT ); Thu, 5 Nov 2015 10:22:54 -0500 Received: from mout.web.de ([212.227.17.11]:57767 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754933AbbKEPWw (ORCPT ); Thu, 5 Nov 2015 10:22:52 -0500 Subject: [PATCH] ACPICA: Delete unnecessary checks before the function call "acpi_ut_strupr" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> To: Len Brown , Lv Zheng , "Rafael J. Wysocki" , Robert Moore , linux-acpi@vger.kernel.org, devel@acpica.org Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <563B7438.6010002@users.sourceforge.net> Date: Thu, 5 Nov 2015 16:22:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:DCiGveu2sigPpclAIjjatPz63r0wn4TnJULzZ2XfgjEK7KE4Tjw Vfcd+MbVaYyiYoJsw84UHX0z0NbJ7SzfHqSa31z4Dgy4u/WpaQQ/AzI17RLk2ngntvlGxMO yysx5ZpLDWCwFvV8I02XNGEOMrOQj71WAeFbDaa6+JzQsUNFrtZ9KH4uYbIxY6rKxMuLLnj GT3sZO2EkUVR3HZdhNDTw== X-UI-Out-Filterresults: notjunk:1;V01:K0:Jkp34utaYOc=:JNEFgYbUnSrB18y+PPddJe pWfG/qR4krCHYtHRswHbf5E5c7qis5IkBbOo3SiQOaPQ7PWFHvBndW8NVMCOACzLYICmWKwAt I2OozZCNdJxiNu7mDmlETxz454c10b/1jxv+cQL9qRo8LAUq3GIJhXpWB2HKBQ4qL7wrB7Gpn z+hJmBygRmx2YLQBAXFpdD2loQCyCuh/kjushJc8Kj915/XWKCh2QBIG5O2SyQDeJegz5x2Z9 jdja5dkklvZKqjSSUdYiv0aqdzIaX7rv1IEI2QO5h0XiDiAut5egXIaxZ82uEXHJsLYf67QgF psFTHm6LcNfL5M6TMKdDPkMNUTqSw3hehNE5lXQTxqigKgCamD3cBXZxaPM+lyA9/VxVQbnVL Zjo7lClw41JjbBcaFnsFZ7hMZDWfnvMThQs4RUCKe6i4OcyWWd27fcnnGRzXmqwSstO/tcqS6 7lRV64KfBBxX8GKDDilTyAyoLCCYkDbbfaolHYYJrZ1lMFghOPvwq55hr/HCJM/3HBI3gBzko AWjQvzdedM3NvPck0jqfcHEI4uBn71QT+f3ZDL+4gr0b24Kr1TzKUpRx8zW8CgrHcV2L+W6gn KHNVeXvq5j9NzOS78fY+uVLhKUT6GJxa3rZZmXHnEj9cQ+YKaMYALugc1l1FFMUoVNMg3sA7C fWTLaKS802sU6xZQw5pfWvFHQ/IibZLnHItm0go5tbxASkkTU4/Vs0hp86bDkxLlxiQejJ57g ScbxlygxSJg8YAi4HbTg9hwxBTvrYOZp8NMiX1KEWePy/KGFAbqoiW1nJtZPFWK5aXl7gO+dg DsAxxgG Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1717 Lines: 58 From: Markus Elfring Date: Thu, 5 Nov 2015 16:12:32 +0100 The acpi_ut_strupr() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/acpi/acpica/dbcmds.c | 9 ++------- drivers/acpi/acpica/dbinput.c | 5 +---- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/acpi/acpica/dbcmds.c b/drivers/acpi/acpica/dbcmds.c index 30414b3..7dcc95a 100644 --- a/drivers/acpi/acpica/dbcmds.c +++ b/drivers/acpi/acpica/dbcmds.c @@ -1131,13 +1131,8 @@ void acpi_db_trace(char *enable_arg, char *method_arg, char *once_arg) u32 debug_layer = 0; u32 flags = 0; - if (enable_arg) { - acpi_ut_strupr(enable_arg); - } - - if (once_arg) { - acpi_ut_strupr(once_arg); - } + acpi_ut_strupr(enable_arg); + acpi_ut_strupr(once_arg); if (method_arg) { if (acpi_db_trace_method_name) { diff --git a/drivers/acpi/acpica/dbinput.c b/drivers/acpi/acpica/dbinput.c index 0480254..aa1dcee 100644 --- a/drivers/acpi/acpica/dbinput.c +++ b/drivers/acpi/acpica/dbinput.c @@ -622,10 +622,7 @@ static u32 acpi_db_get_line(char *input_buffer) } /* Uppercase the actual command */ - - if (acpi_gbl_db_args[0]) { - acpi_ut_strupr(acpi_gbl_db_args[0]); - } + acpi_ut_strupr(acpi_gbl_db_args[0]); count = i; if (count) { -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/