Date: Thu, 05 Nov 2015 10:31:26 -0500 (EST)
Message-Id: <20151105.103126.148818796422971143.davem@davemloft.net>
To: sowmini.varadhan@oracle.com
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, jeffrey.t.kirsher@intel.com,
        jesse.brandeburg@intel.com, shannon.nelson@intel.com,
        carolyn.wyborny@intel.com, donald.c.skidmore@intel.com,
        matthew.vick@intel.com, john.ronciak@intel.com,
        mitch.a.williams@intel.com, andy.shevchenko@gmail.com
Subject: Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM
From: David Miller <davem@davemloft.net>
In-Reply-To: <20151104232100.GJ14575@oracle.com>
References: <20151104232100.GJ14575@oracle.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1362
Lines: 34

From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Date: Wed, 4 Nov 2015 18:21:00 -0500

> This is the i40e equivalent of commit c762dff24c06 ("ixgbe: Look up MAC
> address in Open Firmware or IDPROM").
> 
> As with that fix, attempt to look up the MAC address in Open Firmware
> on systems that support it, and use IDPROM on SPARC if no OF address
> is found.
> 
> In the case of the i40e there is an assumption that the default mac
> address has already been set up as the primary mac filter on probe,
> so if this filter is obtained from the Open Firmware or IDPROM, an
> explicit write is needed via i40e_aq_mac_address_write() and
> i40e_aq_add_macvlan() invocation.
> 
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>

Thanks for doing this.

Longer term we really need an abstract interface by which
architectures can provide a "system" or "firmware" MAC address
which applies to a given 'dev'.

Because these SPARC ifdef'y things really should propagate to
driver after driver after driver.

I'll see if I can cook something up.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/