Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033179AbbKEPzs (ORCPT ); Thu, 5 Nov 2015 10:55:48 -0500 Received: from mail-wi0-f172.google.com ([209.85.212.172]:33058 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033127AbbKEPzq (ORCPT ); Thu, 5 Nov 2015 10:55:46 -0500 From: LABBE Corentin To: linus.walleij@linaro.org, gnurou@gmail.com Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, LABBE Corentin Subject: [PATCH] gpio: 74xx: fix a possible NULL dereference Date: Thu, 5 Nov 2015 16:55:39 +0100 Message-Id: <1446738939-22320-1-git-send-email-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.4.10 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 984 Lines: 32 of_match_device could return NULL, and so cause a NULL pointer dereference later at line 132: priv->flags = (uintptr_t) of_id->data; Reported-by: coverity (CID 1324141) Signed-off-by: LABBE Corentin --- drivers/gpio/gpio-74xx-mmio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-74xx-mmio.c b/drivers/gpio/gpio-74xx-mmio.c index 6ed7c0f..4a7be0f 100644 --- a/drivers/gpio/gpio-74xx-mmio.c +++ b/drivers/gpio/gpio-74xx-mmio.c @@ -120,6 +120,9 @@ static int mmio_74xx_gpio_probe(struct platform_device *pdev) void __iomem *dat; int err; + if (!of_id) + return -ENODEV; + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; -- 2.4.10 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/