Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033465AbbKEQCn (ORCPT ); Thu, 5 Nov 2015 11:02:43 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:37773 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033304AbbKEQCl (ORCPT ); Thu, 5 Nov 2015 11:02:41 -0500 From: LABBE Corentin To: linus.walleij@linaro.org, gnurou@gmail.com Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, LABBE Corentin Subject: [PATCH] gpio: syscon: fix a possible NULL dereference Date: Thu, 5 Nov 2015 17:02:35 +0100 Message-Id: <1446739355-25849-1-git-send-email-clabbe.montjoie@gmail.com> X-Mailer: git-send-email 2.4.10 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 967 Lines: 32 of_match_device could return NULL, and so cause a NULL pointer dereference later at line 199: priv->flags = of_id->data; Reported-by: coverity (CID 1324140) Signed-off-by: LABBE Corentin --- drivers/gpio/gpio-syscon.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c index 045a952..e673c58 100644 --- a/drivers/gpio/gpio-syscon.c +++ b/drivers/gpio/gpio-syscon.c @@ -192,6 +192,9 @@ static int syscon_gpio_probe(struct platform_device *pdev) struct device_node *np = dev->of_node; int ret; + if (!of_id) + return -ENODEV; + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; -- 2.4.10 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/