From: "Moore, Robert" <robert.moore@intel.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>,
        Len Brown <lenb@kernel.org>, "Zheng, Lv" <lv.zheng@intel.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "devel@acpica.org" <devel@acpica.org>
CC: LKML <linux-kernel@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>,
        Julia Lawall <julia.lawall@lip6.fr>
Subject: RE: [PATCH] ACPICA: Delete unnecessary checks before the function
 call "acpi_ut_strupr"
Thread-Topic: [PATCH] ACPICA: Delete unnecessary checks before the function
 call "acpi_ut_strupr"
Thread-Index: AQHRF930a1y5PQYEvEKlnaQt6Ex3fJ6Nnhpg
Date: Thu, 5 Nov 2015 16:28:39 +0000
Message-ID: <94F2FBAB4432B54E8AACC7DFDE6C92E37D98E1D4@ORSMSX112.amr.corp.intel.com>
References: <5307CAA2.8060406@users.sourceforge.net>
 <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6>
 <530A086E.8010901@users.sourceforge.net>
 <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6>
 <530A72AA.3000601@users.sourceforge.net>
 <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6>
 <530B5FB6.6010207@users.sourceforge.net>
 <alpine.DEB.2.10.1402241710370.2074@hadrien>
 <530C5E18.1020800@users.sourceforge.net>
 <alpine.DEB.2.10.1402251014170.2080@hadrien>
 <530CD2C4.4050903@users.sourceforge.net>
 <alpine.DEB.2.10.1402251840450.7035@hadrien>
 <530CF8FF.8080600@users.sourceforge.net>
 <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
 <530DD06F.4090703@users.sourceforge.net>
 <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
 <5317A59D.4@users.sourceforge.net> <563B7438.6010002@users.sourceforge.net>
In-Reply-To: <563B7438.6010002@users.sourceforge.net>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 2259
Lines: 67

Agreed, we will implement your suggestions in the ACPICA code (which is in a different format than the Linux version).


> -----Original Message-----
> From: SF Markus Elfring [mailto:elfring@users.sourceforge.net]
> Sent: Thursday, November 05, 2015 7:23 AM
> To: Len Brown; Zheng, Lv; Wysocki, Rafael J; Moore, Robert; linux-
> acpi@vger.kernel.org; devel@acpica.org
> Cc: LKML; kernel-janitors@vger.kernel.org; Julia Lawall
> Subject: [PATCH] ACPICA: Delete unnecessary checks before the function
> call "acpi_ut_strupr"
> 
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 5 Nov 2015 16:12:32 +0100
> 
> The acpi_ut_strupr() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/acpi/acpica/dbcmds.c  | 9 ++-------
> drivers/acpi/acpica/dbinput.c | 5 +----
>  2 files changed, 3 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/acpi/acpica/dbcmds.c b/drivers/acpi/acpica/dbcmds.c
> index 30414b3..7dcc95a 100644
> --- a/drivers/acpi/acpica/dbcmds.c
> +++ b/drivers/acpi/acpica/dbcmds.c
> @@ -1131,13 +1131,8 @@ void acpi_db_trace(char *enable_arg, char
> *method_arg, char *once_arg)
>  	u32 debug_layer = 0;
>  	u32 flags = 0;
> 
> -	if (enable_arg) {
> -		acpi_ut_strupr(enable_arg);
> -	}
> -
> -	if (once_arg) {
> -		acpi_ut_strupr(once_arg);
> -	}
> +	acpi_ut_strupr(enable_arg);
> +	acpi_ut_strupr(once_arg);
> 
>  	if (method_arg) {
>  		if (acpi_db_trace_method_name) {
> diff --git a/drivers/acpi/acpica/dbinput.c b/drivers/acpi/acpica/dbinput.c
> index 0480254..aa1dcee 100644
> --- a/drivers/acpi/acpica/dbinput.c
> +++ b/drivers/acpi/acpica/dbinput.c
> @@ -622,10 +622,7 @@ static u32 acpi_db_get_line(char *input_buffer)
>  	}
> 
>  	/* Uppercase the actual command */
> -
> -	if (acpi_gbl_db_args[0]) {
> -		acpi_ut_strupr(acpi_gbl_db_args[0]);
> -	}
> +	acpi_ut_strupr(acpi_gbl_db_args[0]);
> 
>  	count = i;
>  	if (count) {
> --
> 2.6.2

????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?