Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756646AbbKESbg (ORCPT ); Thu, 5 Nov 2015 13:31:36 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:37470 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800AbbKESbf (ORCPT ); Thu, 5 Nov 2015 13:31:35 -0500 Date: Thu, 05 Nov 2015 13:31:31 -0500 (EST) Message-Id: <20151105.133131.1900833527415923596.davem@davemloft.net> To: andy.shevchenko@gmail.com Cc: sowmini.varadhan@oracle.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com, shannon.nelson@intel.com, carolyn.wyborny@intel.com, donald.c.skidmore@intel.com, matthew.vick@intel.com, john.ronciak@intel.com, mitch.a.williams@intel.com Subject: Re: [PATCH v6] i40e: Look up MAC address in Open Firmware or IDPROM From: David Miller In-Reply-To: References: <20151105.103126.148818796422971143.davem@davemloft.net> <20151105.110506.1901401372160830603.davem@davemloft.net> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 05 Nov 2015 10:31:35 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 482 Lines: 15 From: Andy Shevchenko Date: Thu, 5 Nov 2015 20:13:21 +0200 > What about > > if (!addr) > return -ENODATA; I totally disagree. of_get_phy_mode() and other similar attribute probing mechanisms use -ENODEV. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/