Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756662AbbKEShq (ORCPT ); Thu, 5 Nov 2015 13:37:46 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:37533 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751284AbbKEShp (ORCPT ); Thu, 5 Nov 2015 13:37:45 -0500 Date: Thu, 05 Nov 2015 13:37:41 -0500 (EST) Message-Id: <20151105.133741.920416694054745930.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, f.fainelli@gmail.com, andrew@lunn.ch Subject: Re: [PATCH net] net: dsa: mv88e6xxx: isolate unbridged ports From: David Miller In-Reply-To: <1446675820-25608-1-git-send-email-vivien.didelot@savoirfairelinux.com> References: <1446675820-25608-1-git-send-email-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 05 Nov 2015 10:37:44 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1104 Lines: 24 From: Vivien Didelot Date: Wed, 4 Nov 2015 17:23:40 -0500 > The DSA documentation specifies that each port must be capable of > forwarding frames to the CPU port. The last changes on bridging support > for the mv88e6xxx driver broke this requirement for non-bridged ports. > > So as for the bridged ports, reserve a few VLANs (4000+) in the switch > to isolate ports that have not been bridged yet. > > By default, a port will be isolated with the CPU and DSA ports. When the > port joins a bridge, it will leave its reserved port. When it is removed > from a bridge, it will join its reserved VLAN again. > > Fixes: 5fe7f68016ff ("net: dsa: mv88e6xxx: fix hardware bridging") > Reported-by: Andrew Lunn > Signed-off-by: Vivien Didelot Applied, thanks Vivien. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/