MIME-Version: 1.0
In-Reply-To: <CA+55aFyXNFu_TfmBjGedCRujoAbhqiBcia7XOtzSq0uxbVv6MA@mail.gmail.com>
References: <20151103111649.GA3477@gmail.com>
	<CA+55aFzcwO+RSLeHOwAYvjZ5AcVvD9Th2=G3R=ZQY1xf+MkDow@mail.gmail.com>
	<20151104233907.GA25925@codemonkey.org.uk>
	<CA+55aFxb14eM6b=ctq65Dx-Ujehj2dbtsVM9rrVOVfLgT=EoHg@mail.gmail.com>
	<20151105021710.GA22941@codemonkey.org.uk>
	<CA+55aFyXNFu_TfmBjGedCRujoAbhqiBcia7XOtzSq0uxbVv6MA@mail.gmail.com>
Date: Thu, 5 Nov 2015 14:04:55 -0800
Message-ID: <CA+55aFwa9XsM7bwoQUU01bh6884_84KiU8rhJ6=LC2QYyDneRQ@mail.gmail.com>
Subject: Re: [GIT PULL] x86/mm changes for v4.4
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Dave Jones <davej@codemonkey.org.uk>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Borislav Petkov <bp@alien8.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andy Lutomirski <luto@kernel.org>,
        Denys Vlasenko <dvlasenk@redhat.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1614
Lines: 45

On Thu, Nov 5, 2015 at 1:27 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> No, I have that. I suspect CONFIG_EFI_PGT_DUMP instead.

Yes, that seems to show the tables, and agrees with the problem address.

So for me I have:

    WARNING: CPU: 1 PID: 1 at arch/x86/mm/dump_pagetables.c:225
note_page+0x5dc/0x780()
    x86/mm: Found insecure W+X mapping at address
ffff88000005f000/0xffff88000005f000

and that 005f000 address also shows up in the firmware tables:

    ACPI: 6 ACPI AML tables successfully acquired and loaded
    ---[ User Space ]---
    0x0000000000000000-0x000000000005f000         380K     RW
       GLB NX pte
    0x000000000005f000-0x0000000000060000           4K     RW
       GLB x  pte
    0x0000000000060000-0x0000000000200000        1664K     RW
       GLB NX pte
    ...
    ---[ Low Kernel Mapping ]---
    0xffff880000000000-0xffff88000005f000         380K     RW
       GLB NX pte
    0xffff88000005f000-0xffff880000060000           4K     RW
       GLB x  pte
    0xffff880000060000-0xffff880000200000        1664K     RW
       GLB NX pte
    ...

and there's quite a few other pages there that are RW but not marked
NX. I suspect they come from the EFI runtime services because the
pattern seems to match what I see in that area, but there's at least a
PSE mapping at START_KERNEL_map too, etc.

                   Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/