Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756891AbbKEWNG (ORCPT ); Thu, 5 Nov 2015 17:13:06 -0500 Received: from mga02.intel.com ([134.134.136.20]:37834 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756192AbbKEWNE (ORCPT ); Thu, 5 Nov 2015 17:13:04 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,249,1444719600"; d="scan'208";a="812813902" Message-ID: <1446761582.26677.77.camel@tzanussi-mobl.amr.corp.intel.com> Subject: Re: [PATCH 00/28] tracing: 'hist' triggers From: Tom Zanussi To: Namhyung Kim Cc: rostedt@goodmis.org, daniel.wagner@bmw-carit.de, masami.hiramatsu.pt@hitachi.com, josh@joshtriplett.org, andi@firstfloor.org, mathieu.desnoyers@efficios.com, peterz@infradead.org, linux-kernel@vger.kernel.org Date: Thu, 05 Nov 2015 16:13:02 -0600 In-Reply-To: <20151105144334.GA28273@danjae.kornet> References: <20151105144334.GA28273@danjae.kornet> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1398 Lines: 47 Hi Namhyung, On Thu, 2015-11-05 at 23:43 +0900, Namhyung Kim wrote: > Hi Tom, > > I implemented 'log2' modifier on top of your v11 patchset. Could you > please take a look at this? > Very nice, thanks for doing this. I just noticed one small problem in that the modifier doesn't get printed in the output. The below patch fixes that. I can just merge that change into your patch and add it to my series, otherwise please let me know what you'd like me to do.. Tom Signed-off-by: Tom Zanussi --- kernel/trace/trace_events_hist.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c index 20a17fd..7621748 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -1092,6 +1092,8 @@ static const char *get_hist_field_flags(struct hist_field *hist_field) flags_str = "execname"; else if (hist_field->flags & HIST_FIELD_SYSCALL) flags_str = "syscall"; + else if (hist_field->flags & HIST_FIELD_LOG2) + flags_str = "log2"; return flags_str; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/