Subject: Re: [PATCH v2 1/2] arm64: dts: exynos7: Add pmic s2mps15 device tree
 node
To: Alim Akhtar <alim.akhtar@samsung.com>, linux-samsung-soc@vger.kernel.org
References: <1446724341-3568-1-git-send-email-alim.akhtar@samsung.com>
Cc: kgene@kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Message-id: <563BEC5C.9040707@samsung.com>
Date: Fri, 06 Nov 2015 08:55:08 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-version: 1.0
In-reply-to: <1446724341-3568-1-git-send-email-alim.akhtar@samsung.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1211
Lines: 35

On 05.11.2015 20:52, Alim Akhtar wrote:
> This patch add pmic (s2mps15) node of espresso board,
> which includes addition of regulators and pmic-clk sub-nodes.

My comment for fixing capital letters was ignored. Do you disagree with it?

> 
> This patch also adds {vmmc,vqmmc}-supply properties for mmc2 node.
> 
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
> Changes since v1:
> * Addressed Javier and Krzysztof review comments.
> * Removed unused ldo/buck nodes.
> * Removed always-on properties from ldo/buck to disable them
> * Added a consumer of pmic supply (like mmc)
> 
>  arch/arm64/boot/dts/exynos/exynos7-espresso.dts |  280 +++++++++++++++++++++++
>  1 file changed, 280 insertions(+)
> 

Rest looks good, so with the fix above:

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/