Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756893AbbKFADZ (ORCPT <rfc822;w@1wt.eu>);
	Thu, 5 Nov 2015 19:03:25 -0500
Received: from mailout4.w1.samsung.com ([210.118.77.14]:28235 "EHLO
	mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750959AbbKFADX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 5 Nov 2015 19:03:23 -0500
X-AuditID: cbfec7f5-f794b6d000001495-1a-563bee4812e8
Subject: Re: [PATCH v6 1/4] Documentation: dt-bindings: Describe SROMc
 configuration
To: Pavel Fedin <p.fedin@samsung.com>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <cover.1446724046.git.p.fedin@samsung.com>
 <26ce9f26ee8537b2f81ad0bf470d1c6b1c8a1a31.1446724046.git.p.fedin@samsung.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Kukjin Kim <kgene@kernel.org>
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Message-id: <563BEE44.4040207@samsung.com>
Date: Fri, 06 Nov 2015 09:03:16 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-version: 1.0
In-reply-to: <26ce9f26ee8537b2f81ad0bf470d1c6b1c8a1a31.1446724046.git.p.fedin@samsung.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrHLMWRmVeSWpSXmKPExsVy+t/xq7oe76zDDP4f4rWYf+Qcq0X/m4Ws
	FuderWS0eP3C0KL/8Wtmi02Pr7FaXN41h81ixvl9TBZLr19ksnh1aRWbxYTpa1ksWvceYXfg
	8Vgzbw2jx+W+XiaPlcu/sHlsWtXJ5rF5Sb1H35ZVjB6fN8kFsEdx2aSk5mSWpRbp2yVwZZx4
	vJm14JNIRefGfvYGxsf8XYycHBICJhKtJzYyQ9hiEhfurWfrYuTiEBJYyijxcVIzK4TzhVGi
	5cosdpAqYYEwiTVPZrCDJEQE1jBKLD93kBGiqo1RYu+bSWD9zAIPGCXuX25iBGlhEzCW2Lx8
	CRuIzSugJbFq6iqwOIuAqsShaydYQWxRgQiJiRMaWCFqBCV+TL7HAmJzCsRIzHi/FKieA2io
	nsT9i1ogYWYBeYnNa94yT2AUmIWkYxZC1SwkVQsYmVcxiqaWJhcUJ6XnGukVJ+YWl+al6yXn
	525ihMTK1x2MS49ZHWIU4GBU4uE1WG4dJsSaWFZcmXuIUYKDWUmEt+YYUIg3JbGyKrUoP76o
	NCe1+BCjNAeLkjjvzF3vQ4QE0hNLUrNTUwtSi2CyTBycUg2MdXwv12fEHn94lenbkzL9oo+l
	Lf/8fv6XvOZy9/eb9ca+zke1ri6JumR1O90xu1vw912F35+5UxiNfv24771m8hZBEZY2e5lu
	rQKfl4v0FYKlv1TdO/Pmb1yl4oI9zJuXSLzbFZWnViuZ5pakOVHKoatq1Q91Y8MJ7JkOS7/y
	/MrNfRq489MWJZbijERDLeai4kQArGTBf5ECAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2858
Lines: 66

On 05.11.2015 21:03, Pavel Fedin wrote:
> Add documentation for new subnode properties, allowing bank configuration.
> Based on u-boot implementation, but heavily reworked.
> 
> Also, fix size of SROMc mapping in the example.
> 
> Signed-off-by: Pavel Fedin <p.fedin@samsung.com>
> ---
>  .../bindings/arm/samsung/exynos-srom.txt           | 71 +++++++++++++++++++++-
>  1 file changed, 69 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/samsung/exynos-srom.txt b/Documentation/devicetree/bindings/arm/samsung/exynos-srom.txt
> index 33886d5..cce5c1f 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/exynos-srom.txt
> +++ b/Documentation/devicetree/bindings/arm/samsung/exynos-srom.txt
> @@ -5,8 +5,75 @@ Required properties:
>  
>  - reg: offset and length of the register set
>  
> -Example:
> +Optional properties:
> +The SROM controller can be used to attach external peripherals. In this case
> +extra properties, describing the bus behind it, should be specified as below:
> +
> +- #address-cells: Must be set to 2 to allow memory address translation
> +
> +- #size-cells: Must be set to 1 to allow CS address passing
> +
> +- ranges: Must be set up to reflect the memory layout with four integer values
> +	  per bank:
> +		<bank-number> 0 <physical address of bank> <size>
> +
> +Sub-nodes:
> +The actual device nodes should be added as subnodes to the SROMc node. These
> +subnodes, except regular device specification, should contain the following
> +properties, describing configuration of the relevant SROM bank:
> +
> +Required properties:
> +- reg: bank number, base address (relative to start of the bank) and size of
> +       the memory mapped for the device. Note that base address will be
> +       typically 0 as this is the start of the bank.
> +
> +- samsung,srom-timing : array of 6 integers, specifying bank timings in the
> +                        following order: Tacp, Tcah, Tcoh, Tacc, Tcos, Tacs.
> +                        Each value is specified in cycles and has the following
> +                        meaning and valid range:
> +                        Tacp : Page mode access cycle at Page mode (0 - 15)
> +                        Tcah : Address holding time after CSn (0 - 15)
> +                        Tcoh : Chip selection hold on OEn (0 - 15)
> +                        Tacc : Access cycle (0 - 32)

All of the manuals have error here. Probably it can be either: 1-32 or
0-31. I would bet on 0-31, what do you think?

Rest looks good:

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/