Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966074AbbKFA3D (ORCPT ); Thu, 5 Nov 2015 19:29:03 -0500 Received: from mail-ig0-f170.google.com ([209.85.213.170]:35351 "EHLO mail-ig0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965331AbbKFA3A (ORCPT ); Thu, 5 Nov 2015 19:29:00 -0500 MIME-Version: 1.0 In-Reply-To: <563BEC5C.9040707@samsung.com> References: <1446724341-3568-1-git-send-email-alim.akhtar@samsung.com> <563BEC5C.9040707@samsung.com> From: Alim Akhtar Date: Fri, 6 Nov 2015 05:58:20 +0530 Message-ID: Subject: Re: [PATCH v2 1/2] arm64: dts: exynos7: Add pmic s2mps15 device tree node To: Krzysztof Kozlowski Cc: Alim Akhtar , "linux-samsung-soc@vger.kernel.org" , kgene , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1629 Lines: 50 On Fri, Nov 6, 2015 at 5:25 AM, Krzysztof Kozlowski wrote: > On 05.11.2015 20:52, Alim Akhtar wrote: >> This patch add pmic (s2mps15) node of espresso board, >> which includes addition of regulators and pmic-clk sub-nodes. > > My comment for fixing capital letters was ignored. Do you disagree with it? > Ah! sorry about that, I missed that completely, will re-send. Thanks! >> >> This patch also adds {vmmc,vqmmc}-supply properties for mmc2 node. >> >> Signed-off-by: Abhilash Kesavan >> Signed-off-by: Alim Akhtar >> Reviewed-by: Javier Martinez Canillas >> --- >> Changes since v1: >> * Addressed Javier and Krzysztof review comments. >> * Removed unused ldo/buck nodes. >> * Removed always-on properties from ldo/buck to disable them >> * Added a consumer of pmic supply (like mmc) >> >> arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 280 +++++++++++++++++++++++ >> 1 file changed, 280 insertions(+) >> > > Rest looks good, so with the fix above: > > Reviewed-by: Krzysztof Kozlowski > > Best regards, > Krzysztof > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Regards, Alim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/