Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031904AbbKFE5K (ORCPT ); Thu, 5 Nov 2015 23:57:10 -0500 Received: from helcar.hengli.com.au ([209.40.204.226]:51840 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030793AbbKFE5I (ORCPT ); Thu, 5 Nov 2015 23:57:08 -0500 Date: Fri, 6 Nov 2015 12:56:39 +0800 From: Herbert Xu To: Maxime Ripard Cc: LABBE Corentin , davem@davemloft.net, wens@csie.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, stable@vger.kernel.org Subject: Re: [PATCH] crypto: sun4i-ss: add missing statesize Message-ID: <20151106045639.GA14722@gondor.apana.org.au> References: <1446709737-11316-1-git-send-email-clabbe.montjoie@gmail.com> <20151105160719.GG6114@lukather> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151105160719.GG6114@lukather> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1279 Lines: 35 On Thu, Nov 05, 2015 at 08:07:19AM -0800, Maxime Ripard wrote: > > On Thu, Nov 05, 2015 at 08:48:57AM +0100, LABBE Corentin wrote: > > sun4i-ss implementaton of md5/sha1 is via ahash algorithms. > > A recent change make impossible to load them without giving statesize. > > Which one? We recently disabled ahash drivers that do not declare statesize because it can lead to a crash when the driver is used through algif. Not declaring statesize is a bug anyway but the fact that it is exported through algif makes it much worse. > > This patch specifiy statesize for sha1 and md5. > > > > Signed-off-by: LABBE Corentin > > Cc: stable@vger.kernel.org > > Please also add a Fixes tag (and the stable version it applies to). I don't see the point for a fixes tag as it would simply refer to the original patch-set that added the driver. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/