Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757280AbbKFG3F (ORCPT ); Fri, 6 Nov 2015 01:29:05 -0500 Received: from mail9.hitachi.co.jp ([133.145.228.44]:52693 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757261AbbKFG3D (ORCPT ); Fri, 6 Nov 2015 01:29:03 -0500 From: =?utf-8?B?5bmz5p2+6ZuF5bezIC8gSElSQU1BVFXvvIxNQVNBTUk=?= To: "'acme@kernel.org'" CC: "'Wang Nan'" , "namhyung@kernel.org" , "lizefan@huawei.com" , "pi3orama@163.com" , "linux-kernel@vger.kernel.org" , "jolsa@kernel.org" Subject: RE: [PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success Thread-Topic: [PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success Thread-Index: AQHRF8ymF/ZtKuEPKE6WPBpva1M0JZ6Naimw//+VagCAAYlX0A== Date: Fri, 6 Nov 2015 06:28:58 +0000 Message-ID: <50399556C9727B4D88A595C8584AAB3752606DC9@GSjpTKYDCembx32.service.hitachi.net> References: <1446729565-27592-1-git-send-email-wangnan0@huawei.com> <1446729565-27592-3-git-send-email-wangnan0@huawei.com> <50399556C9727B4D88A595C8584AAB3752604844@GSjpTKYDCembx32.service.hitachi.net> <20151105160000.GX13236@kernel.org> In-Reply-To: <20151105160000.GX13236@kernel.org> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.198.219.51] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tA66T9XG025889 Content-Length: 1412 Lines: 34 From: acme@kernel.org [mailto:acme@kernel.org] > >Em Thu, Nov 05, 2015 at 02:08:48PM +0000, 平松雅巳 / HIRAMATU，MASAMI escreveu: >> From: Wang Nan [mailto:wangnan0@huawei.com] >> > >> >It is possible that find_perf_probe_point_from_map() fails to find >> >symbol but still returns 0 because of an small error when coding: >> >find_perf_probe_point_from_map() set 'ret' to error code at first, >> >but also use it to hold return value of >> >kernel_get_symbol_address_by_name(). >> >> OK, I didn't expect that there is a symbol which can be found by >> kernel_get_symbol_address_by_name() but not by __find_kernel_function()... > >> Would you have any example of the error? >> >> > >> >This patch resets 'ret' to error even kernel_get_symbol_address_by_name() >> >success, so if !sym, the whole function returns error correctly. >> >> Hmm, that sounds tricky. I'd rather like to add *psym to kernel_get_symbol_address_by_name() >> to save symbol and don't use __find_kernel_function() instead. > >Tricky? I don't think so, suboptimal? possibly, but it fixes an error, >so should be processed quickly, right? I'm applying his patch and then >whatever improvement can be done on top. OK, then I'll send an improvement patch. Thanks, > >- Arnaldo ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?