Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032151AbbKFGsu (ORCPT ); Fri, 6 Nov 2015 01:48:50 -0500 Received: from TYO202.gate.nec.co.jp ([210.143.35.52]:46391 "EHLO tyo202.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032021AbbKFGss convert rfc822-to-8bit (ORCPT ); Fri, 6 Nov 2015 01:48:48 -0500 From: Naoya Horiguchi To: Sasha Levin CC: Andrew Morton , "Kirill A. Shutemov" , Wanpeng Li , "Andi Kleen" , Andrea Arcangeli , "Hugh Dickins" , Minchan Kim , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Naoya Horiguchi Subject: Re: [PATCH v1] mm: hwpoison: adjust for new thp refcounting Thread-Topic: [PATCH v1] mm: hwpoison: adjust for new thp refcounting Thread-Index: AQHRGFoIwRcB10XEkEWAEqJv8GW3Bp6N8g2AgAAEcoA= Date: Fri, 6 Nov 2015 06:47:44 +0000 Message-ID: <20151106064743.GA30023@hori1.linux.bs1.fc.nec.co.jp> References: <1446790309-15683-1-git-send-email-n-horiguchi@ah.jp.nec.com> <563C4955.3000300@oracle.com> In-Reply-To: <563C4955.3000300@oracle.com> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.128.101.24] Content-Type: text/plain; charset="iso-2022-jp" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 825 Lines: 19 On Fri, Nov 06, 2015 at 01:31:49AM -0500, Sasha Levin wrote: > On 11/06/2015 01:11 AM, Naoya Horiguchi wrote: > > In the new refcounting, we no longer use tail->_mapcount to keep tail's > > refcount, and thereby we can simplify get_hwpoison_page() and remove > > put_hwpoison_page() (by replacing with put_page()). > > This is confusing for the reader (and some static analysis tools): this adds > put_page()s without corresponding get_page()s. > > Could we instead macro put_hwpoison_page() as put_page() for the sake of readability? OK, I'll do this. Thanks, Naoya Horiguchi-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/