Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033041AbbKFJ3m (ORCPT ); Fri, 6 Nov 2015 04:29:42 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:49472 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032528AbbKFJ3S (ORCPT ); Fri, 6 Nov 2015 04:29:18 -0500 Date: Fri, 6 Nov 2015 09:28:42 +0000 From: Mark Brown To: Shunqian Zheng Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, heiko@sntech.de, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, benzh@chromium.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Message-ID: <20151106092842.GT18409@sirena.org.uk> References: <1446717194-8572-1-git-send-email-zhengsq@rock-chips.com> <1446717194-8572-2-git-send-email-zhengsq@rock-chips.com> <20151105161311.GR18409@sirena.org.uk> <563C61A9.2080105@rock-chips.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="v15hXiddb3kq3Bam" Content-Disposition: inline In-Reply-To: <563C61A9.2080105@rock-chips.com> X-Cookie: Put your trust in those who are worthy. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 217.140.96.141 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1533 Lines: 42 --v15hXiddb3kq3Bam Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 06, 2015 at 04:15:37PM +0800, Shunqian Zheng wrote: > On 2015=E5=B9=B411=E6=9C=8806=E6=97=A5 00:13, Mark Brown wrote: > >On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: > >This looks like a simple boolean control rather than an enum - it looks > >like it's just turning antipop on and off. > It is a boolean control, but it takes 2 bits -- the value of "on" is b10 = and > b01 for "off". > So I try to use VALUE_ENUM. The presentation of the control to userspace needs to be a Switch, this is probably going to need you to code something custom. --v15hXiddb3kq3Bam Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWPHLAAAoJECTWi3JdVIfQjAcH/0Fj5h17AbC5k1Tz8Hvh6BoK H9eGlwWW9vIUqaQU7Qi+jsVNaFcfgDJNUOXeBpndeubzxD4pHlWRS9lgM3xsW+F6 kpWAg5Mqqqb24gnUwYxva2W45J5rQdA2V8dIs08jUUlmVjytqldIofSi3oZUecIv vEmpKv3t7O228qO4RzKFJ5vFY3qQ26KcFvtazmBeCreLO1Q11NxeGX9RxtKm8FXs sDpRqsZ/pyZ8i5GO+eZZLVUW2W5DJv88KoOmgi2v1jdHdsE1ToIr27QAtw4oWf4t ehqcu4SleYXhMTaaiPp/OsvBzcHheclWB2rxCVQHDCgMOPYIQ2Q0EzUcTTJkqGo= =vFLB -----END PGP SIGNATURE----- --v15hXiddb3kq3Bam-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/