From: Heiko Stuebner <heiko@sntech.de>
To: Zain Wang <zain.wang@rock-chips.com>
Cc: zhengsq@rock-chips.com, hl@rock-chips.com, herbert@gondor.apana.org.au,
        davem@davemloft.net, mturquette@baylibre.com, pawel.moll@arm.com,
        ijc+devicetree@hellion.org.uk, robh+dt@kernel.org,
        galak@codeaurora.org, linux@arm.linux.org.uk, mark.rutland@arm.com,
        linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
        linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
        eddie.cai@rock-chips.com
Subject: Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288
Date: Fri, 06 Nov 2015 11:12:55 +0100
Message-ID: <4509145.eZ7GP0e6gb@phil>
User-Agent: KMail/4.14.10 (Linux/4.2.0-1-amd64; KDE/4.14.13; x86_64; ; )
In-Reply-To: <1446772644-2352-4-git-send-email-zain.wang@rock-chips.com>
References: <1446772644-2352-1-git-send-email-zain.wang@rock-chips.com> <1446772644-2352-4-git-send-email-zain.wang@rock-chips.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1564
Lines: 55

Am Freitag, 6. November 2015, 09:17:23 schrieb Zain Wang:
> Add Crypto drivers for rk3288 including crypto controller and dma clk.
> 
> Signed-off-by: Zain Wang <zain.wang@rock-chips.com>
> ---
> 
> Changed in v2:
> - None
> 
> Changed in v1:
> - remove the _crypto suffix
> - use "rockchip,rk3288-crypto" instead of "rockchip,rk3288"
> 
>  arch/arm/boot/dts/rk3288.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 6a79c9c..7b7914e 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -170,6 +170,21 @@
>  		};
>  	};
>  
> +	crypto: cypto-controller@ff8a0000 {
> +		compatible = "rockchip,rk3288-crypto";
> +		reg = <0xff8a0000 0x4000>;
> +		interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&cru ACLK_CRYPTO>,
> +			 <&cru HCLK_CRYPTO>,
> +			 <&cru SCLK_CRYPTO>,
> +			 <&cru ACLK_DMAC1>;
> +		clock-names = "aclk",
> +			      "hclk",
> +			      "sclk",
> +			      "apb_pclk";
> +		status = "okay";
> +	};
> +

please move that whole node to the right location. Entries are sorted by 
register address (the ff8a0000 should then of course be below  i2s@ff890000 
and above vop@ff930000)


>  	reserved-memory {
>  		#address-cells = <1>;
>  		#size-cells = <1>;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/