Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757338AbbKFPYi (ORCPT ); Fri, 6 Nov 2015 10:24:38 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:36809 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752343AbbKFPYg (ORCPT ); Fri, 6 Nov 2015 10:24:36 -0500 Date: Fri, 6 Nov 2015 17:24:33 +0200 From: "Kirill A. Shutemov" To: Vladimir Davydov Cc: "Kirill A. Shutemov" , Andrew Morton , Andrea Arcangeli , Hugh Dickins , Naoya Horiguchi , Sasha Levin , Minchan Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: add page_check_address_transhuge helper Message-ID: <20151106152433.GA23298@node.shutemov.name> References: <1446564375-72143-1-git-send-email-kirill.shutemov@linux.intel.com> <1446564375-72143-5-git-send-email-kirill.shutemov@linux.intel.com> <20151105091013.GC29259@esperanza> <20151105092459.GC7614@node.shutemov.name> <20151105120726.GD29259@esperanza> <20151105123606.GE7614@node.shutemov.name> <20151105125354.GE29259@esperanza> <20151105125838.GF7614@node.shutemov.name> <20151106143707.GL29259@esperanza> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151106143707.GL29259@esperanza> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1190 Lines: 40 On Fri, Nov 06, 2015 at 05:37:07PM +0300, Vladimir Davydov wrote: > diff --git a/mm/rmap.c b/mm/rmap.c > index 0837487d3737..7ac775e41820 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -796,48 +796,43 @@ int page_mapped_in_vma(struct page *page, struct vm_area_struct *vma) > return 1; > } > > -struct page_referenced_arg { > - int mapcount; > - int referenced; > - unsigned long vm_flags; > - struct mem_cgroup *memcg; > -}; > /* > - * arg: page_referenced_arg will be passed > + * Check that @page is mapped at @address into @mm. In contrast to > + * page_check_address(), this function can handle transparent huge pages. > + * > + * On success returns true with pte mapped and locked. For transparent huge > + * pages *@ptep is set to NULL. I think "For PMD-mapped transparent huge pages"... would be more correct. Otherwise looks great! Reviewed-by: Kirill A. Shutemov -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/