Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966238AbbKFRjN (ORCPT ); Fri, 6 Nov 2015 12:39:13 -0500 Received: from mail-pa0-f50.google.com ([209.85.220.50]:36348 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966223AbbKFRjJ (ORCPT ); Fri, 6 Nov 2015 12:39:09 -0500 Message-ID: <563CE5BB.2080701@linaro.org> Date: Fri, 06 Nov 2015 09:39:07 -0800 From: "Shi, Yang" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Catalin Marinas CC: Will Deacon , Mark Rutland , linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option References: <1446658671-16238-1-git-send-email-yang.shi@linaro.org> <20151106123008.GK6087@arm.com> <20151106125002.GA8116@leverpostej> <20151106162109.GZ7637@e104818-lin.cambridge.arm.com> <20151106162538.GU6087@arm.com> <563CE21A.6060803@linaro.org> <20151106173558.GC7637@e104818-lin.cambridge.arm.com> In-Reply-To: <20151106173558.GC7637@e104818-lin.cambridge.arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1070 Lines: 33 On 11/6/2015 9:35 AM, Catalin Marinas wrote: > On Fri, Nov 06, 2015 at 09:23:38AM -0800, Shi, Yang wrote: >> On 11/6/2015 8:25 AM, Will Deacon wrote: >>> However, the patch would allow one to >>> disable FRAME_POINTERS (not sure it has any effect on the aarch64 gcc >>> though). >> >> No, it doesn't. Actually, FRAME_POINTER could be disabled regardless of the >> patch. > > In which case I suggest that we always select it just as a clearer > statement that the feature cannot be disabled (and you never know what > the compiler people decide to do in the future). Do you mean select FRAME_POINTER in ARCH_WANT_FRAME_POINTERS? Yes, we could, but this may cause other architectures which select ARCH_WANT_FRAME_POINTERS to have FRAME_POINTER selected too. Or we could do: select FRAME_POINTER is ARM64 Thanks, Yang > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/