Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030524AbbKFTHL (ORCPT ); Fri, 6 Nov 2015 14:07:11 -0500 Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:50159 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751821AbbKFTHJ (ORCPT ); Fri, 6 Nov 2015 14:07:09 -0500 Date: Fri, 6 Nov 2015 20:07:05 +0100 From: Florian Westphal To: Pablo Neira Ayuso Cc: Dmitry Safonov <0x7f454c46@gmail.com>, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kaber@trash.net, coreteam@netfilter.org, netfilter-devel@vger.kernel.org, kadlec@blackhole.kfki.hu, davem@davemloft.net Subject: Re: [netfilter-core] [PATCH] net: netfilter: fix GCC uninitialized warning Message-ID: <20151106190705.GA20345@breakpoint.cc> References: <1446835694-6967-1-git-send-email-0x7f454c46@gmail.com> <20151106191008.GA2362@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20151106191008.GA2362@salvia> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1846 Lines: 40 Pablo Neira Ayuso wrote: > On Fri, Nov 06, 2015 at 09:48:14PM +0300, Dmitry Safonov wrote: > > With x86_64_defconfig: > > GCC thinks that in nfulnl_recv_config flags parameter is not inited but > > it was under the same condition (nfula[NFULA_CFG_FLAGS] == true). > > Suppress this warning: > > net/netfilter/nfnetlink_log.c: In function ‘nfulnl_recv_config’: > > net/netfilter/nfnetlink_log.c:320:14: warning: ‘flags’ may be used uninitialized in this function [-Wmaybe-uninitialized] > > inst->flags = flags; > > ^ > > Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com> > > --- > > net/netfilter/nfnetlink_log.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c > > index 06eb48fceb42e4..d65f3b987b7f13 100644 > > --- a/net/netfilter/nfnetlink_log.c > > +++ b/net/netfilter/nfnetlink_log.c > > @@ -825,7 +825,7 @@ nfulnl_recv_config(struct sock *ctnl, struct sk_buff *skb, > > struct net *net = sock_net(ctnl); > > struct nfnl_log_net *log = nfnl_log_pernet(net); > > int ret = 0; > > - u16 flags; > > + u16 flags = 0; /* GCC uninitialized */ > > u16 uninitialized_var(flags); ? I also see warnings in nfqueue: net/netfilter/nfnetlink_queue.c:1083:11: warning: 'nfnl_ct' may be used uninitialized in this function [-Wmaybe-uninitialized] net/netfilter/nfnetlink_queue.c:519:19: warning: 'nfnl_ct' may be used uninitialized in this function [-Wmaybe-uninitialized] Both are false positives, but it would be nice if we could silence these. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/