Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757568AbbKFTCq (ORCPT ); Fri, 6 Nov 2015 14:02:46 -0500 Received: from mail.us.es ([193.147.175.20]:56322 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751821AbbKFTCo (ORCPT ); Fri, 6 Nov 2015 14:02:44 -0500 X-Qmail-Scanner-Diagnostics: from 127.0.0.1 by antivirus1 (envelope-from , uid 501) with qmail-scanner-2.10 (clamdscan: 0.98.7/21038. spamassassin: 3.4.0. Clear:RC:1(127.0.0.1):SA:0(-103.2/7.5):. Processed in 1.841555 secs); 06 Nov 2015 19:02:43 -0000 X-Spam-ASN: AS12715 87.216.0.0/16 X-Envelope-From: pneira@us.es Date: Fri, 6 Nov 2015 20:10:08 +0100 From: Pablo Neira Ayuso To: Dmitry Safonov <0x7f454c46@gmail.com> Cc: kaber@trash.net, kadlec@blackhole.kfki.hu, davem@davemloft.net, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: netfilter: fix GCC uninitialized warning Message-ID: <20151106191008.GA2362@salvia> References: <1446835694-6967-1-git-send-email-0x7f454c46@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1446835694-6967-1-git-send-email-0x7f454c46@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1475 Lines: 37 On Fri, Nov 06, 2015 at 09:48:14PM +0300, Dmitry Safonov wrote: > With x86_64_defconfig: > GCC thinks that in nfulnl_recv_config flags parameter is not inited but > it was under the same condition (nfula[NFULA_CFG_FLAGS] == true). > Suppress this warning: > net/netfilter/nfnetlink_log.c: In function ‘nfulnl_recv_config’: > net/netfilter/nfnetlink_log.c:320:14: warning: ‘flags’ may be used uninitialized in this function [-Wmaybe-uninitialized] > inst->flags = flags; > ^ > Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com> > --- > net/netfilter/nfnetlink_log.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c > index 06eb48fceb42e4..d65f3b987b7f13 100644 > --- a/net/netfilter/nfnetlink_log.c > +++ b/net/netfilter/nfnetlink_log.c > @@ -825,7 +825,7 @@ nfulnl_recv_config(struct sock *ctnl, struct sk_buff *skb, > struct net *net = sock_net(ctnl); > struct nfnl_log_net *log = nfnl_log_pernet(net); > int ret = 0; > - u16 flags; > + u16 flags = 0; /* GCC uninitialized */ u16 uninitialized_var(flags); ? > if (nfula[NFULA_CFG_CMD]) { > u_int8_t pf = nfmsg->nfgen_family; > -- > 2.6.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/