Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966030AbbKFTNi (ORCPT ); Fri, 6 Nov 2015 14:13:38 -0500 Received: from mail-wi0-f173.google.com ([209.85.212.173]:38624 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964918AbbKFTNh convert rfc822-to-8bit (ORCPT ); Fri, 6 Nov 2015 14:13:37 -0500 MIME-Version: 1.0 In-Reply-To: <20151106191008.GA2362@salvia> References: <1446835694-6967-1-git-send-email-0x7f454c46@gmail.com> <20151106191008.GA2362@salvia> From: Dmitry Safonov <0x7f454c46@gmail.com> Date: Fri, 6 Nov 2015 22:13:16 +0300 Message-ID: Subject: Re: [PATCH] net: netfilter: fix GCC uninitialized warning To: Pablo Neira Ayuso Cc: Patrick McHardy , kadlec@blackhole.kfki.hu, davem@davemloft.net, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1769 Lines: 42 I thought, it was decided to use 0/NULL/whatever, than uninitialized_var()? Is right now? http://thread.gmane.org/gmane.linux.kernel/1383415 2015-11-06 22:10 GMT+03:00 Pablo Neira Ayuso : > On Fri, Nov 06, 2015 at 09:48:14PM +0300, Dmitry Safonov wrote: >> With x86_64_defconfig: >> GCC thinks that in nfulnl_recv_config flags parameter is not inited but >> it was under the same condition (nfula[NFULA_CFG_FLAGS] == true). >> Suppress this warning: >> net/netfilter/nfnetlink_log.c: In function ‘nfulnl_recv_config’: >> net/netfilter/nfnetlink_log.c:320:14: warning: ‘flags’ may be used uninitialized in this function [-Wmaybe-uninitialized] >> inst->flags = flags; >> ^ >> Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com> >> --- >> net/netfilter/nfnetlink_log.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/netfilter/nfnetlink_log.c b/net/netfilter/nfnetlink_log.c >> index 06eb48fceb42e4..d65f3b987b7f13 100644 >> --- a/net/netfilter/nfnetlink_log.c >> +++ b/net/netfilter/nfnetlink_log.c >> @@ -825,7 +825,7 @@ nfulnl_recv_config(struct sock *ctnl, struct sk_buff *skb, >> struct net *net = sock_net(ctnl); >> struct nfnl_log_net *log = nfnl_log_pernet(net); >> int ret = 0; >> - u16 flags; >> + u16 flags = 0; /* GCC uninitialized */ > > u16 uninitialized_var(flags); ? > >> if (nfula[NFULA_CFG_CMD]) { >> u_int8_t pf = nfmsg->nfgen_family; >> -- >> 2.6.2 >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/