Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162920AbbKFUyf (ORCPT ); Fri, 6 Nov 2015 15:54:35 -0500 Received: from smtp07.smtpout.orange.fr ([80.12.242.129]:38442 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162395AbbKFUyd (ORCPT ); Fri, 6 Nov 2015 15:54:33 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Fri, 06 Nov 2015 21:54:30 +0100 X-ME-IP: 90.38.168.74 From: Robert Jarzmik To: Charles Keepax , Mark Brown Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: wm9713: add gpio chip References: <1446657164-25012-1-git-send-email-robert.jarzmik@free.fr> <20151104183322.GD2549@ck-lbox> <87oaf9bls9.fsf@belgarion.home> <20151106092913.GC3378@x1> <20151106092733.GG2549@ck-lbox> <20151106094828.GD3378@x1> X-URL: http://belgarath.falguerolles.org/ Date: Fri, 06 Nov 2015 21:47:35 +0100 In-Reply-To: <20151106094828.GD3378@x1> (Lee Jones's message of "Fri, 6 Nov 2015 09:48:28 +0000") Message-ID: <87r3k2am8o.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1547 Lines: 39 Lee Jones writes: > On Fri, 06 Nov 2015, Charles Keepax wrote: > >> On Fri, Nov 06, 2015 at 09:29:13AM +0000, Lee Jones wrote: >> > On Wed, 04 Nov 2015, Robert Jarzmik wrote: >> > >> > > Charles Keepax writes: >> > > >> > > > On Wed, Nov 04, 2015 at 06:12:44PM +0100, Robert Jarzmik wrote: >> > > >> The Wolfson WM9713 provides 8 GPIOs. If the gpiolib is compiled in the >> > > >> kernel, declare a gpio chip. >> > > >> >> > > >> Signed-off-by: Robert Jarzmik >> >> Apologies Lee, we are discussing a patch that adds a GPIO driver >> into an AC97 CODEC. I had suggested that perhaps we should put >> the GPIO driver as a seperate driver under GPIO and link the two >> with an MFD. But Mark has already replied in the thread to say >> that he doesn't think that will be necessary. Although he did >> raise some concerns that perhaps it could be done more generally >> as it should apply to other AC97 CODECs as well. >> >> So I think you can probably safely ignore this for now, sorry >> for the noise. Ok, so where I should target this code at ? Should this land in sound/soc/soc-ac97.c ? Or somewhere else ? I'd like to see where you think the init_gpio() and free_gpio() should be put. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/