Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033928AbbKFWH3 (ORCPT ); Fri, 6 Nov 2015 17:07:29 -0500 Received: from mta01.ornl.gov ([128.219.177.14]:26441 "EHLO mta01.ornl.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030287AbbKFWH2 convert rfc822-to-8bit (ORCPT ); Fri, 6 Nov 2015 17:07:28 -0500 X-SG: RELAYLIST X-IronPort-AV: E=Sophos;i="5.20,254,1444708800"; d="scan'208";a="115598970" From: "Simmons, James A." To: "'Amitoj Kaur Chawla'" , "oleg.drokin@intel.com" , "andreas.dilger@intel.com" , "gregkh@linuxfoundation.org" , "lustre-devel@lists.lustre.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: RE: [lustre-devel] [PATCH] staging: lustre: lnet: klnds: socklnd: Move extern declarations to header Thread-Topic: [lustre-devel] [PATCH] staging: lustre: lnet: klnds: socklnd: Move extern declarations to header Thread-Index: AQHRGKNmJ0RhiSrExU+PebXWeBM4j56PjZFQ Date: Fri, 6 Nov 2015 22:07:26 +0000 Message-ID: <700a373b14c14161b9893727da948ab5@EXCHCS32.ornl.gov> References: <20151106145652.GA16452@amitoj-Inspiron-3542> In-Reply-To: <20151106145652.GA16452@amitoj-Inspiron-3542> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [128.219.12.132] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2521 Lines: 59 >From: lustre-devel [mailto:lustre-devel-bounces@lists.lustre.org] On Behalf Of Amitoj Kaur Chawla >Sent: Friday, November 06, 2015 9:57 AM >To: oleg.drokin@intel.com; andreas.dilger@intel.com; gregkh@linuxfoundation.org; lustre-devel@lists.lustre.org; devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org >Subject: [lustre-devel] [PATCH] staging: lustre: lnet: klnds: socklnd: Move extern declarations to header > >This patch moves extern declarations in socklnd_lib.c to the respective >header file, 'socklnd.h'. > >This patch also removes extern keyword from function declarations >since functions have the extern specifier by default. > >Signed-off-by: Amitoj Kaur Chawla >--- > drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h | 3 +++ > drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c | 2 -- > 2 files changed, 3 insertions(+), 2 deletions(-) Acked-by: James Simmons diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h index b349847..f4fa725 100644 --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.h @@ -679,6 +679,9 @@ int ksocknal_lib_recv_kiov(ksock_conn_t *conn); int ksocknal_lib_get_conn_tunables(ksock_conn_t *conn, int *txmem, int *rxmem, int *nagle); +void ksocknal_read_callback(ksock_conn_t *conn); +void ksocknal_write_callback(ksock_conn_t *conn); + int ksocknal_tunables_init(void); void ksocknal_lib_csum_tx(ksock_tx_t *tx); diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c index 679785b..04a4653 100644 --- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c +++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib.c @@ -580,8 +580,6 @@ ksocknal_lib_push_conn(ksock_conn_t *conn) ksocknal_connsock_decref(conn); } -extern void ksocknal_read_callback(ksock_conn_t *conn); -extern void ksocknal_write_callback(ksock_conn_t *conn); /* * socket call back in Linux */ -- 1.9.1 _______________________________________________ lustre-devel mailing list lustre-devel@lists.lustre.org http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/