Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033959AbbKFWR7 (ORCPT ); Fri, 6 Nov 2015 17:17:59 -0500 Received: from mail-ig0-f177.google.com ([209.85.213.177]:36858 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030298AbbKFWR6 convert rfc822-to-8bit (ORCPT ); Fri, 6 Nov 2015 17:17:58 -0500 MIME-Version: 1.0 In-Reply-To: References: <1446847163-9643-1-git-send-email-punitvara@gmail.com> Date: Sat, 7 Nov 2015 03:47:57 +0530 Message-ID: Subject: Re: [PATCH] Staging: wilc1000: Declare *wilc in init_wilc_driver to fix build error From: punit vara To: Greg KH Cc: glen.lee@atmel.com, linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Punit Vara Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2804 Lines: 67 On Sat, Nov 7, 2015 at 3:39 AM, punit vara wrote: > On Sat, Nov 7, 2015 at 3:29 AM, Punit Vara wrote: >> This patch is to the linux_wlan.c file that fixes declaration of *wilc >> to remove following error while building it. >> >> make drivers/staging/wilc1000/linux_wlan.o >> drivers/staging/wilc1000/linux_wlan.c:1824:24: error: ‘wilc’ undeclared >> >> Signed-off-by: Punit Vara >> --- >> drivers/staging/wilc1000/linux_wlan.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c >> index 2a5b36f..0805050 100644 >> --- a/drivers/staging/wilc1000/linux_wlan.c >> +++ b/drivers/staging/wilc1000/linux_wlan.c >> @@ -1780,6 +1780,7 @@ int wilc_netdev_init(struct wilc **wilc) >> /*The 1st function called after module inserted*/ >> static int __init init_wilc_driver(void) >> { >> + struct wilc *wilc; >> #ifdef WILC_SPI >> struct wilc *wilc; >> #endif >> -- >> 2.6.2 >> > drivers/staging/wilc1000/linux_wlan.c: In function ‘wilc1000_wlan_init’: > drivers/staging/wilc1000/linux_wlan.c:1109:3: error: implicit > declaration of function ‘init_irq’ > [-Werror=implicit-function-declaration] > if (init_irq(dev)) { > ^ > drivers/staging/wilc1000/linux_wlan.c: In function ‘init_wilc_driver’: > drivers/staging/wilc1000/linux_wlan.c:1824:24: error: ‘wilc’ > undeclared (first use in this function) > if (wilc_netdev_init(&wilc)) > ^ > drivers/staging/wilc1000/linux_wlan.c:1824:24: note: each undeclared > identifier is reported only once for each function it appears in > cc1: some warnings being treated as errors > scripts/Makefile.build:258: recipe for target > 'drivers/staging/wilc1000/linux_wlan.o' failed > make[1]: *** [drivers/staging/wilc1000/linux_wlan.o] Error 1 > Makefile:1526: recipe for target 'drivers/staging/wilc1000/linux_wlan.o' failed > make: *** [drivers/staging/wilc1000/linux_wlan.o] Error 2 > > There were two errors generated by make drivers/staging/wilc1000/linux_wlan.o > One error I have removed second one I will resolve tomorrow. Should I > remove function init_irq defination from #ifdef ? or any better > solution to remove this error? Today I have fetched greg staging tree I have found make drivers/staging/wilc1000/linux_wlan.o build failed. So I am just trying to fix it . I removed one error and send patch to get some feedback about second error. I will be sending whole patch fixing both errors. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/