Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757845AbbKFXl0 (ORCPT ); Fri, 6 Nov 2015 18:41:26 -0500 Received: from hauke-m.de ([5.39.93.123]:52617 "EHLO hauke-m.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753134AbbKFXlY (ORCPT ); Fri, 6 Nov 2015 18:41:24 -0500 Message-ID: <563D3AA1.6050508@hauke-m.de> Date: Sat, 07 Nov 2015 00:41:21 +0100 From: Hauke Mehrtens User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Jon Mason CC: Kapil Hali , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Ray Jui , Scott Branden , Florian Fainelli , Gregory Fong , Lee Jones , Kever Yang , Maxime Ripard , Olof Johansson , Paul Walmsley , Linus Walleij , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH v3 4/4] ARM: BCM: Add SMP support for Broadcom 4708 References: <1446844273-6460-1-git-send-email-kapilh@broadcom.com> <1446844273-6460-5-git-send-email-kapilh@broadcom.com> <563D1ED1.6050506@hauke-m.de> <20151106225419.GP8792@broadcom.com> <563D3777.3050208@hauke-m.de> In-Reply-To: <563D3777.3050208@hauke-m.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2083 Lines: 62 On 11/07/2015 12:27 AM, Hauke Mehrtens wrote: > On 11/06/2015 11:54 PM, Jon Mason wrote: >> On Fri, Nov 06, 2015 at 10:42:41PM +0100, Hauke Mehrtens wrote: >>> On 11/06/2015 10:11 PM, Kapil Hali wrote: >>>> From: Jon Mason >>>> >>>> Add SMP support for Broadcom's 4708 SoCs. >>>> >>>> Signed-off-by: Jon Mason >>>> Acked-by: Hauke Mehrtens >>>> Tested-by: Hauke Mehrtens >>>> Signed-off-by: Kapil Hali >>> >>> I tested this on a Netgear R6250 V1 (BCM4708) and SMP worked. >>> >>>> --- >>>> arch/arm/boot/dts/bcm4708.dtsi | 2 ++ >>>> arch/arm/mach-bcm/Kconfig | 1 + >>>> arch/arm/mach-bcm/Makefile | 3 +++ >>>> 3 files changed, 6 insertions(+) >>>> >>> >>> ... >>> >>>> --- a/arch/arm/mach-bcm/Kconfig >>>> +++ b/arch/arm/mach-bcm/Kconfig >>>> @@ -54,6 +54,7 @@ config ARCH_BCM_NSP >>>> config ARCH_BCM_5301X >>>> bool "Broadcom BCM470X / BCM5301X ARM SoC" if ARCH_MULTI_V7 >>>> select ARCH_BCM_IPROC >>> >>> You activated ARM_ERRATA_764369 for NSP is this not needed for NS? >> >> I'm not certain the CPU version, and without that it is difficult to >> know what errata's are present in the underlying hardware. My guess >> is that all present in NSP are present in NS (for UP and SMP). This >> would put it as: >> select ARM_ERRATA_754322 >> select ARM_ERRATA_775420 >> select ARM_ERRATA_764369 if SMP >> >> Would you like me to have them added? >> > > I will send a separate patch adding all the workarounds for erratas in > the CPU core and the cache controller. > > Hauke > > Hi, BCM4708 uses a Cortex-A9 rev r3p0 and a L2C-310 rev r3p2. For this CPU and cache controller the same workaround are needed as for NSP, if you will resend this patch, please add all of them. Hauke -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/