Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757740AbbKFX4k (ORCPT ); Fri, 6 Nov 2015 18:56:40 -0500 Received: from mail-yk0-f175.google.com ([209.85.160.175]:33223 "EHLO mail-yk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753134AbbKFX4i (ORCPT ); Fri, 6 Nov 2015 18:56:38 -0500 MIME-Version: 1.0 In-Reply-To: <1446802612-5828-1-git-send-email-lyz@rock-chips.com> References: <1446802612-5828-1-git-send-email-lyz@rock-chips.com> Date: Fri, 6 Nov 2015 15:56:37 -0800 X-Google-Sender-Auth: wkOz9ul4OFraFhERF73TReLo1oE Message-ID: Subject: Re: [RFC] usb: dwc2: hcd: fix split schedule issue From: Doug Anderson To: Yunzhi Li Cc: John Youn , Julius Werner , Dinh Nguyen , "Kaukab, Yousaf" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , wulf , Kever Yang , caesar , Tao Huang , rockchip-discuss Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1734 Lines: 43 lyz@, On Fri, Nov 6, 2015 at 1:36 AM, Yunzhi Li wrote: > Fix dwc2 split schedule sequence issue. Not schedule a SSPLIT_IN > packet between SSPLIT-begin and SSPLIT-end. > > Signed-off-by: Yunzhi Li > --- > drivers/usb/dwc2/hcd.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c > index e79baf7..a32ed01 100644 > --- a/drivers/usb/dwc2/hcd.c > +++ b/drivers/usb/dwc2/hcd.c > @@ -1122,6 +1122,10 @@ static void dwc2_process_periodic_channels(struct dwc2_hsotg *hsotg) > break; > } > > + if (qh->channel->xact_pos == DWC2_HCSPLT_XACTPOS_BEGIN || > + qh->channel->xact_pos == DWC2_HCSPLT_XACTPOS_MID) > + break; > + > /* > * In Slave mode, stay on the current transfer until there is > * nothing more to do or the high-bandwidth request count is Just a quite note to say that this doesn't seem to resolve the weird errors I'm seeing with the "Microsoft Wireless Keyboard 2000" that I have. I see split transaction errors in a USB analyzer with just that hooked up behind a hub (don't even need any other USB devices). ...it is possible that there are two unrelated problems here, but it's also possible that there's some bigger root cause that will fix both of our problems. I've been poking at things a bit too, but so far no luck... -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/