Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751781AbbKGHcS (ORCPT ); Sat, 7 Nov 2015 02:32:18 -0500 Received: from mga01.intel.com ([192.55.52.88]:36706 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884AbbKGHcR convert rfc822-to-8bit (ORCPT ); Sat, 7 Nov 2015 02:32:17 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,256,1444719600"; d="scan'208";a="845345057" From: "Dilger, Andreas" To: Shivani Bhardwaj , "gregkh@linuxfoundation.org" CC: "Drokin, Oleg" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/3] Staging: lustre: tracefile: Remove function prototype Thread-Topic: [PATCH 3/3] Staging: lustre: tracefile: Remove function prototype Thread-Index: AQHRGLfWncvLLIMUnkGa6wl4e/xx7J6QPOoA Date: Sat, 7 Nov 2015 07:32:15 +0000 Message-ID: References: <42174300898e4900b870cb925e33296185816f0a.1446830119.git.shivanib134@gmail.com> In-Reply-To: <42174300898e4900b870cb925e33296185816f0a.1446830119.git.shivanib134@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.202.223] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2001 Lines: 58 On 2015/11/06, 10:19, "Shivani Bhardwaj" wrote: >Remove the prototype of function cfs_trace_free_string_buffer() as it is >no longer needed. These patches would be a lot more useful if the summary contained the name of the function being removed, rather than "remove function prototype" and variations of that. Something like: staging: lustre: remove cfs_trace_free_string_buffer prototype staging: lustre: remove ldlm_pool_set_limit wrapper staging: lustre: remove ldlm_pool_get_limit wrapper Not sure if that is grounds for rejection of this patch series (I'll leave that up to Dan and Greg), but definitely something for future patches. Cheers, Andreas >Signed-off-by: Shivani Bhardwaj >--- > drivers/staging/lustre/lustre/libcfs/tracefile.h | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/drivers/staging/lustre/lustre/libcfs/tracefile.h >b/drivers/staging/lustre/lustre/libcfs/tracefile.h >index 73d60e0..ba62005 100644 >--- a/drivers/staging/lustre/lustre/libcfs/tracefile.h >+++ b/drivers/staging/lustre/lustre/libcfs/tracefile.h >@@ -70,7 +70,6 @@ int cfs_trace_copyin_string(char *knl_buffer, int >knl_buffer_nob, > int cfs_trace_copyout_string(char __user *usr_buffer, int usr_buffer_nob, > const char *knl_str, char *append); > int cfs_trace_allocate_string_buffer(char **str, int nob); >-void cfs_trace_free_string_buffer(char *str, int nob); > int cfs_trace_dump_debug_buffer_usrstr(void __user *usr_str, int >usr_str_nob); > int cfs_trace_daemon_command(char *str); > int cfs_trace_daemon_command_usrstr(void __user *usr_str, int >usr_str_nob); >-- >2.1.0 > > Cheers, Andreas -- Andreas Dilger Lustre Software Architect Intel High Performance Data Division -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/