Date: Sat, 7 Nov 2015 02:19:32 -0800
From: Christoph Hellwig <hch@infradead.org>
To: Mike Christie <mchristi@redhat.com>
Cc: Bart Van Assche <bart.vanassche@sandisk.com>,
        device-mapper development <dm-devel@redhat.com>,
        linux-fsdevel@vger.kernel.org, linux-raid@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
        drbd-dev@lists.linbit.com
Subject: Re: [dm-devel] [PATCH 19/32] block: add helper to get data dir from
 op
Message-ID: <20151107101932.GC12117@infradead.org>
References: <1446674909-5371-1-git-send-email-mchristi@redhat.com>
 <1446674909-5371-20-git-send-email-mchristi@redhat.com>
 <563A8A33.3000002@sandisk.com>
 <563B930F.7040705@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <563B930F.7040705@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 761
Lines: 14

On Thu, Nov 05, 2015 at 11:34:07AM -0600, Mike Christie wrote:
> I can do that. You are right in how they are used. I just did the above,
> to follow the other *_data_dir calls.

I think the *_data_dir calls are horrible interfaces.  But your series
already is huge, so if it makes your life easier I'd say keep it as-is
for now.  But in the long run we should have the interfaces that Bart
suggested, and one that gives you a dma_data_direction from a request,
as that's what a lot of the driver ultimatively want.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/