Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753489AbbKGOCm (ORCPT ); Sat, 7 Nov 2015 09:02:42 -0500 Received: from mail-yk0-f174.google.com ([209.85.160.174]:35034 "EHLO mail-yk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753214AbbKGOCj (ORCPT ); Sat, 7 Nov 2015 09:02:39 -0500 MIME-Version: 1.0 Date: Sat, 7 Nov 2015 17:02:36 +0300 Message-ID: Subject: Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru From: Dmitry Krivenok To: Jerry Hoemann Cc: ross.zwisler@linux.intel.com, rjw@rjwysocki.net, lenb@kernel.org, dan.j.williams@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1651 Lines: 44 > + if (IS_ENABLED(CONFIG_ACPI_NFIT_DEBUG)) { > + dev_dbg(dev, "%s:%s cmd: %d input length: %d\n", __func__, > + dimm_name, cmd, in_buf.buffer.length); > + print_hex_dump_debug("cmd: ", DUMP_PREFIX_OFFSET, 4, > + 4, in_buf.buffer.pointer, min_t(u32, 128, > + in_buf.buffer.length), true); > + } Maybe move this code to a helper function? There are 4 almost identical blocks now in acpi_nfit_ctl_passthru and acpi_nfit_ctl_intel. > + for (i = 0; i < ARRAY_SIZE(pkg.h.res); i++) > + if (pkg.h.res[i]) > + return -EINVAL; I'd rename "res" to "reserved" for clarity. > + /* This may be bigger that the fixed portion of the pakcage */ s/that/than/ s/pakcage/package/ > + switch (type) { > + case NVDIMM_TYPE_INTEL: > + rc = __nd_ioctl(nvdimm_bus, nvdimm, ro, cmd, arg); > + break; > + case NVDIMM_TYPE_PASSTHRU: > + rc = __nd_ioctl_passthru(nvdimm_bus, nvdimm, ro, cmd, arg); > + break; > + default: > + rc = -ENOTTY; > + } The same comment. Identical code in nd_ioctl and nvdimm_ioctl. Perhaps move to a helper function? Thanks, Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/