Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754001AbbKGQ0e (ORCPT ); Sat, 7 Nov 2015 11:26:34 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:53728 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753972AbbKGQ0a (ORCPT ); Sat, 7 Nov 2015 11:26:30 -0500 Message-ID: <1446913569.6006.95.camel@decadent.org.uk> Subject: Re: [PATCH 4.2 073/110] i2c: mv64xxx: really allow I2C offloading From: Ben Hutchings To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Hezi Shahmoon , Thomas Petazzoni , Wolfram Sang Date: Sat, 07 Nov 2015 16:26:09 +0000 In-Reply-To: <20151106191707.646625164@linuxfoundation.org> References: <20151106191703.247930828@linuxfoundation.org> <20151106191707.646625164@linuxfoundation.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-jni/+GVB6WfTga7M8r84" X-Mailer: Evolution 3.18.1-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 217.140.96.141 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3350 Lines: 90 --=-jni/+GVB6WfTga7M8r84 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2015-11-06 at 11:19 -0800, Greg Kroah-Hartman wrote: > 4.2-stable review patch.=C2=A0=C2=A0If anyone has any objections, please = let me know. >=20 > ------------------ >=20 > From: Hezi Shahmoon >=20 > commit 0729a04977d497cf66234fd7f900ddcec3ef1c52 upstream. >=20 > Commit 00d8689b85a7 ("i2c: mv64xxx: rework offload support to fix > several problems") completely reworked the offload support, but left a > debugging-related "return false" at the beginning of the > mv64xxx_i2c_can_offload() function. This has the unfortunate consequence > that offloading is in fact never used, which wasn't really the > intention. >=20 > This commit fixes that problem by removing the bogus "return false". This looks like enabling a feature rather than fixing a bug. =C2=A0As it's not a critical feature, this doesn't seem suitable for stable. Ben. > Fixes: 00d8689b85a7 ("i2c: mv64xxx: rework offload support to fix several= problems") > Signed-off-by: Hezi Shahmoon > [Thomas: reworked commit log and title.] > Signed-off-by: Thomas Petazzoni > Signed-off-by: Wolfram Sang > Signed-off-by: Greg Kroah-Hartman >=20 > --- > =C2=A0drivers/i2c/busses/i2c-mv64xxx.c |=C2=A0=C2=A0=C2=A0=C2=A02 -- > =C2=A01 file changed, 2 deletions(-) >=20 > --- a/drivers/i2c/busses/i2c-mv64xxx.c > +++ b/drivers/i2c/busses/i2c-mv64xxx.c > @@ -669,8 +669,6 @@ mv64xxx_i2c_can_offload(struct mv64xxx_i > =C2=A0> > struct i2c_msg *msgs =3D drv_data->msgs; > =C2=A0> > int num =3D drv_data->num_msgs; > =C2=A0 > -> > return false; > - > =C2=A0> > if (!drv_data->offload_enabled) > =C2=A0> > > return false; > =C2=A0 >=20 >=20 > -- > To unsubscribe from this list: send the line "unsubscribe stable" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at=C2=A0=C2=A0http://vger.kernel.org/majordomo-info.h= tml --=20 Ben Hutchings 73.46% of all statistics are made up. --=-jni/+GVB6WfTga7M8r84 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIVAwUAVj4mIee/yOyVhhEJAQr8iQ//TqA4yn5uoINGGHueGbBm2dxBa61V/+2G zokiBu5fkFmKwxTRBkLXKyy48eU67JF9AmWB/SLsyCEP6vaCVsCeS7NjJUlu/syW Oqo5AjXxid2B86hbpCYsIPbP8fSZBrdZTmO5PElTI1iEKL2YNSMPFkUBHTGyETVm 8O0zAupATYvoyzdH8NyLBe1PLoP01TMimJz9Ttsli0oy6qDzgcO2NTarSJznAAi7 lJT8iKFmLQX03RDBhh9XRbE6pC4+8J0kHQrYlnkxORbp1jyLeSwPsvMLDU+XP3Tu 1dqNnmKvr8beDy2o2E7KlKKmu9m7n0kF+JVKq5OxCuH550yrlLO23H6Fw/+Zhhtb 1JbCfAUAbyexzEppzWRpULx6uWDnkBY0Ivy7kToJemJ2Q4X4OGmDm2Hzkydc5LSX V0O0hAAsAjXFV38WgIVXwS+7eQkTSLZ6yWfz35meSFLnwrDTpCegEAK2H1C6gegD 7gMr3ZR/WNFmF7+Zm1tWlTMoVeLXxbzd+xT0f4zrraoln4pT+DFqw71G6a2vKUMf p0CF+jra4SP97Ff4MyPJ1KdP7F/n23xLrm1fVG/1kXaO7Am6VtTTVByqr35d32Zz jxSJ67O17GlH7ccTPEgimk+Wbg1UsH8Z75Vq57gVacYSAKpt+Y77q73F2DEaN6yi LmX0pzHQQPg= =u3W/ -----END PGP SIGNATURE----- --=-jni/+GVB6WfTga7M8r84-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/