Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754224AbbKGVja (ORCPT ); Sat, 7 Nov 2015 16:39:30 -0500 Received: from mga02.intel.com ([134.134.136.20]:64889 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752400AbbKGVjY (ORCPT ); Sat, 7 Nov 2015 16:39:24 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,258,1444719600"; d="scan'208";a="845666479" Date: Sat, 7 Nov 2015 23:39:19 +0200 From: Jarkko Sakkinen To: Jeremiah Mahler , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, gregkh@linuxfoundation.org, jgunthorpe@obsidianresearch.com, dhowells@redhat.com, artem.bityutskiy@linux.intel.com, Marcel Selhorst , David Safford , Mimi Zohar , "open list:KEYS-TRUSTED" , "open list:KEYS-TRUSTED" Subject: Re: [PATCH 08/10] tpm: seal/unseal for TPM 2.0 Message-ID: <20151107213919.GA13027@intel.com> References: <1445020843-9382-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1445020843-9382-9-git-send-email-jarkko.sakkinen@linux.intel.com> <20151107185803.GA3375@newt.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151107185803.GA3375@newt.localdomain> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1543 Lines: 44 On Sat, Nov 07, 2015 at 10:58:03AM -0800, Jeremiah Mahler wrote: > Jarkko, > > On Fri, Oct 16, 2015 at 09:40:27PM +0300, Jarkko Sakkinen wrote: > > Added tpm_trusted_seal() and tpm_trusted_unseal() API for sealing > > trusted keys. > > > > This patch implements basic sealing and unsealing functionality for > > TPM 2.0: > > > > * Seal with a parent key using a 20 byte auth value. > > * Unseal with a parent key using a 20 byte auth value. > > > > Signed-off-by: Jarkko Sakkinen > > --- > > drivers/char/tpm/tpm-interface.c | 76 ++++++++++++ > > drivers/char/tpm/tpm.h | 15 ++- > > drivers/char/tpm/tpm2-cmd.c | 250 ++++++++++++++++++++++++++++++++++++++- > > include/keys/trusted-type.h | 2 +- > > include/linux/tpm.h | 26 ++++ > > 5 files changed, 366 insertions(+), 3 deletions(-) > > > > This patch adds a lot of code but doesn't use any of it until later > patches. This can make using 'git bisect' more difficult because it > will point to the wrong patches. If this were my patch series I would > combine this patch with the later ones that actually start using the > code. > > [...] I do agree with you that it'd had been a good idea. Thanks for the feedback. > -- > - Jeremiah Mahler > -- /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/