Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933139AbbKGXLu (ORCPT ); Sat, 7 Nov 2015 18:11:50 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:35124 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933091AbbKGXLt (ORCPT ); Sat, 7 Nov 2015 18:11:49 -0500 Date: Sat, 7 Nov 2015 15:11:47 -0800 From: Jeremiah Mahler To: Jarkko Sakkinen Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, gregkh@linuxfoundation.org, jgunthorpe@obsidianresearch.com, dhowells@redhat.com, artem.bityutskiy@linux.intel.com, Tejun Heo , NeilBrown , Guenter Roeck , "Eric W. Biederman" Subject: Re: [BUG, PATCH 03/10] sysfs: added __compat_only_sysfs_link_entry_to_kobj() Message-ID: <20151107231147.GA9273@newt.localdomain> Mail-Followup-To: Jeremiah Mahler , Jarkko Sakkinen , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, gregkh@linuxfoundation.org, jgunthorpe@obsidianresearch.com, dhowells@redhat.com, artem.bityutskiy@linux.intel.com, Tejun Heo , NeilBrown , Guenter Roeck , "Eric W. Biederman" References: <1445020843-9382-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1445020843-9382-4-git-send-email-jarkko.sakkinen@linux.intel.com> <20151107025518.GB2911@newt.localdomain> <20151107105543.GA6897@intel.com> <20151107114137.GA5100@intel.com> <20151107180856.GA2250@newt.localdomain> <20151107223109.GA16578@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151107223109.GA16578@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1831 Lines: 54 Jarkko, On Sun, Nov 08, 2015 at 12:31:09AM +0200, Jarkko Sakkinen wrote: > On Sat, Nov 07, 2015 at 10:08:56AM -0800, Jeremiah Mahler wrote: > > Jarkko, > > > > On Sat, Nov 07, 2015 at 01:41:37PM +0200, Jarkko Sakkinen wrote: > > > On Sat, Nov 07, 2015 at 12:55:43PM +0200, Jarkko Sakkinen wrote: > > > > On Fri, Nov 06, 2015 at 06:55:18PM -0800, Jeremiah Mahler wrote: > > > > > Jarkko, > > > > > [...] > > > I pushed a fix over here: > > > > > > https://github.com/jsakkine/linux-tpmdd/tree/fixes > > > > > This fix does work since it effectively avoids the call to > > __compat_only_sysfs_link_entry_to_kobj(). > > > > Have you tested cases where __compat_only_sysfs_link_entry_to_kobj() > > is actually used? > > Yes, of course I have. And I checked your DSDT and my assumption was > correct. There was no DSM in the ACPI object. > > However, there is probably another regression but it is caused by some > patch that was added earlier. I strongly believe it is not caused by any > of my 4.4 patches. > > I think what was happening with you was that > __compat_only_sysfs_link_entry_to_kobj() was returning -ENOENT, which it > should do when target is not found. This was propagated to tpm_tis and > it probably messes up clean up somehow. > > I have to test my hypothesis as soon as possible. The fix that I pushed > is still valid no matter which way the things are. > > > [...] > > > > -- > > - Jeremiah Mahler > > /Jarkko It sounds like you have the problem figured out and have a good fix. If I can do anything else to help let me know :-) -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/