Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754074AbbKHDEP (ORCPT ); Sat, 7 Nov 2015 22:04:15 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:33841 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753207AbbKHDEH (ORCPT ); Sat, 7 Nov 2015 22:04:07 -0500 Date: Sat, 7 Nov 2015 19:04:04 -0800 From: Jeremiah Mahler To: Jarkko Sakkinen Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, gregkh@linuxfoundation.org, jgunthorpe@obsidianresearch.com, dhowells@redhat.com, artem.bityutskiy@linux.intel.com, Tejun Heo , NeilBrown , Guenter Roeck , "Eric W. Biederman" Subject: Re: [BUG, PATCH 03/10] sysfs: added __compat_only_sysfs_link_entry_to_kobj() Message-ID: <20151108030404.GA2231@newt.localdomain> Mail-Followup-To: Jeremiah Mahler , Jarkko Sakkinen , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, gregkh@linuxfoundation.org, jgunthorpe@obsidianresearch.com, dhowells@redhat.com, artem.bityutskiy@linux.intel.com, Tejun Heo , NeilBrown , Guenter Roeck , "Eric W. Biederman" References: <1445020843-9382-1-git-send-email-jarkko.sakkinen@linux.intel.com> <1445020843-9382-4-git-send-email-jarkko.sakkinen@linux.intel.com> <20151107025518.GB2911@newt.localdomain> <20151107105543.GA6897@intel.com> <20151107114137.GA5100@intel.com> <20151107180856.GA2250@newt.localdomain> <20151107223109.GA16578@intel.com> <20151107231147.GA9273@newt.localdomain> <20151108004906.GA25843@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151108004906.GA25843@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1249 Lines: 38 Jarkko, On Sun, Nov 08, 2015 at 02:49:06AM +0200, Jarkko Sakkinen wrote: > On Sat, Nov 07, 2015 at 03:11:47PM -0800, Jeremiah Mahler wrote: > > Jarkko, > > [...] > > > > It sounds like you have the problem figured out and have a good fix. > > If I can do anything else to help let me know :-) > > Turns out that after all the second issue that I described was also > because of this patch. > > Clean up was not done properly when that function. I revised my fix. > > If you want to help, check that the revised patch works I'll add > Tested-by to the patch. Thank you! > > > -- > > - Jeremiah Mahler > > /Jarkko I tested the patch (link below) and it works with one small caveat. The patch would not apply because line 231 uses list_add_tail_rcu instead of list_add_rcu. I am working from commit 9b774d5cf2d where the problem started. Your repo likely has other changes involved. https://github.com/jsakkine/linux-tpmdd/commit/73ea7e0b8045f9610c3274bcefaf89b7a05ee781 -- - Jeremiah Mahler -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/