Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754393AbbKHFIw (ORCPT ); Sun, 8 Nov 2015 00:08:52 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:42307 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751901AbbKHFIv (ORCPT ); Sun, 8 Nov 2015 00:08:51 -0500 Subject: Re: [PATCH V3 2/4] dma: add Qualcomm Technologies HIDMA management driver To: Sinan Kaya , dmaengine@vger.kernel.org, cov@codeaurora.org, jcm@redhat.com Cc: agross@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Vinod Koul , Dan Williams , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <1446958380-23298-1-git-send-email-okaya@codeaurora.org> <1446958380-23298-3-git-send-email-okaya@codeaurora.org> From: Timur Tabi Message-ID: <563ED8DF.6090307@codeaurora.org> Date: Sat, 7 Nov 2015 23:08:47 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:41.0) Gecko/20100101 Firefox/41.0 SeaMonkey/2.38 MIME-Version: 1.0 In-Reply-To: <1446958380-23298-3-git-send-email-okaya@codeaurora.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1203 Lines: 31 Sinan Kaya wrote: > + val = val & ~(MAX_BUS_REQ_LEN_MASK << MAX_BUS_WR_REQ_BIT_POS); > + val = val | (mgmtdev->max_write_request << MAX_BUS_WR_REQ_BIT_POS); > + val = val & ~(MAX_BUS_REQ_LEN_MASK); > + val = val | (mgmtdev->max_read_request); val &= ~MAX_BUS_REQ_LEN_MASK << MAX_BUS_WR_REQ_BIT_POS; val |= mgmtdev->max_write_request << MAX_BUS_WR_REQ_BIT_POS; val &= ~MAX_BUS_REQ_LEN_MASK; val |= mgmtdev->max_read_request; > +static const struct of_device_id hidma_mgmt_match[] = { > + { .compatible = "qcom,hidma-mgmt", }, > + { .compatible = "qcom,hidma-mgmt-1.0", }, > + { .compatible = "qcom,hidma-mgmt-1.1", }, > + {}, > +}; I thought Rob said that he did NOT want to use version numbers in compatible strings. And what's the difference between these three versions anyway? -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/