Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753036AbbKHIrb (ORCPT ); Sun, 8 Nov 2015 03:47:31 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:36618 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751359AbbKHIr3 (ORCPT ); Sun, 8 Nov 2015 03:47:29 -0500 From: Saurabh Sengar To: joern@lazybastard.org, dwmw2@infradead.org, computersforpeace@gmail.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Saurabh Sengar Subject: [PATCH] mtd: phram: error handling Date: Sun, 8 Nov 2015 14:17:20 +0530 Message-Id: <1446972440-3795-1-git-send-email-saurabh.truth@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1289 Lines: 47 registering the device with NULL pointer can lead to crash, hence fixing it. Signed-off-by: Saurabh Sengar --- in case of 'illegal start address' or 'illegal device length', name pointer is getting freed. we shouldn't register the device with NULL pointer. drivers/mtd/devices/phram.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c index 8b66e52..9a7aed3 100644 --- a/drivers/mtd/devices/phram.c +++ b/drivers/mtd/devices/phram.c @@ -249,12 +249,14 @@ static int phram_setup(const char *val) if (ret) { kfree(name); parse_err("illegal start address\n"); + goto err; } ret = parse_num64(&len, token[2]); if (ret) { kfree(name); parse_err("illegal device length\n"); + goto err; } ret = register_device(name, start, len); @@ -262,7 +264,7 @@ static int phram_setup(const char *val) pr_info("%s device: %#llx at %#llx\n", name, len, start); else kfree(name); - +err: return ret; } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/