Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751462AbbKHKzI (ORCPT ); Sun, 8 Nov 2015 05:55:08 -0500 Received: from mail-ig0-f173.google.com ([209.85.213.173]:34590 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823AbbKHKzF (ORCPT ); Sun, 8 Nov 2015 05:55:05 -0500 MIME-Version: 1.0 In-Reply-To: <1440515579-5359-1-git-send-email-benjamin.tissoires@redhat.com> References: <1440515579-5359-1-git-send-email-benjamin.tissoires@redhat.com> Date: Sun, 8 Nov 2015 11:55:04 +0100 Message-ID: Subject: Re: [PATCH v3] Input: uinput - add new UINPUT_DEV_SETUP and UI_ABS_SETUP ioctl From: Elias Vanderstuyft To: Benjamin Tissoires Cc: Dmitry Torokhov , David Herrmann , Peter Hutterer , "open list:HID CORE LAYER" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2036 Lines: 61 Hi, On Tue, Aug 25, 2015 at 5:12 PM, Benjamin Tissoires wrote: > diff --git a/include/uapi/linux/uinput.h b/include/uapi/linux/uinput.h > index 013c9d8..ef6c9f5 100644 > --- a/include/uapi/linux/uinput.h > +++ b/include/uapi/linux/uinput.h > @@ -20,6 +20,11 @@ > * Author: Aristeu Sergio Rozanski Filho > * > * Changes/Revisions: > + * 0.5 08/13/2015 (David Herrmann & > + * Benjamin Tissoires ) > + * - add UI_DEV_SETUP ioctl > + * - add UI_ABS_SETUP ioctl > + * - add UI_GET_VERSION ioctl > * 0.4 01/09/2014 (Benjamin Tissoires ) > * - add UI_GET_SYSNAME ioctl > * 0.3 24/05/2006 (Anssi Hannula ) > @@ -37,8 +42,8 @@ > #include > #include > > -#define UINPUT_VERSION 4 > - > +#define UINPUT_VERSION 5 > +#define UINPUT_MAX_NAME_SIZE 80 > > struct uinput_ff_upload { > __u32 request_id; > @@ -58,6 +63,79 @@ struct uinput_ff_erase { > #define UI_DEV_CREATE _IO(UINPUT_IOCTL_BASE, 1) > #define UI_DEV_DESTROY _IO(UINPUT_IOCTL_BASE, 2) > > +struct uinput_setup { > + struct input_id id; > + char name[UINPUT_MAX_NAME_SIZE]; > + __u32 ff_effects_max; > +}; Is there a reason to not follow the same field order as in struct uinput_user_dev? I.e., why not: struct uinput_setup { char name[UINPUT_MAX_NAME_SIZE]; struct input_id id; __u32 ff_effects_max; }; In case you would change this, also make sure to change the order in the documentation of UI_DEV_SETUP. Cheers, Elias -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/