Date: Sun, 8 Nov 2015 09:50:03 -0800
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: LABBE Corentin <clabbe.montjoie@gmail.com>, davem@davemloft.net,
        wens@csie.org, linux-crypto@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-sunxi@googlegroups.com, stable@vger.kernel.org
Subject: Re: [PATCH] crypto: sun4i-ss: add missing statesize
Message-ID: <20151108175003.GT6114@lukather>
References: <1446709737-11316-1-git-send-email-clabbe.montjoie@gmail.com>
 <20151105160719.GG6114@lukather>
 <20151106045639.GA14722@gondor.apana.org.au>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="rwSwrS9OkH+FvIfA"
Content-Disposition: inline
In-Reply-To: <20151106045639.GA14722@gondor.apana.org.au>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2659
Lines: 74


--rwSwrS9OkH+FvIfA
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Nov 06, 2015 at 12:56:39PM +0800, Herbert Xu wrote:
> On Thu, Nov 05, 2015 at 08:07:19AM -0800, Maxime Ripard wrote:
> >=20
> > On Thu, Nov 05, 2015 at 08:48:57AM +0100, LABBE Corentin wrote:
> > > sun4i-ss implementaton of md5/sha1 is via ahash algorithms.
> > > A recent change make impossible to load them without giving statesize.
> >=20
> > Which one?
>=20
> We recently disabled ahash drivers that do not declare statesize
> because it can lead to a crash when the driver is used through
> algif.

"Recently" is relative and really doesn't help.

Having the commit ID that made this change is an absolute reference,
and really helps to identify when that behaviour changed.

> Not declaring statesize is a bug anyway but the fact that it
> is exported through algif makes it much worse.
>=20
> > > This patch specifiy statesize for sha1 and md5.
> > >=20
> > > Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
> > > Cc: stable@vger.kernel.org
> >=20
> > Please also add a Fixes tag (and the stable version it applies to).
>=20
> I don't see the point for a fixes tag as it would simply refer
> to the original patch-set that added the driver.

What's the problem with that?

Maxime

--=20
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

--rwSwrS9OkH+FvIfA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJWP4tLAAoJEBx+YmzsjxAgtcQP/R4jt2Oy7uob5CQ2ppaLqZhW
QQszQ0WNQthEE1illM7pFsE9BkkNFBPPh53zkiKqgqpSNTUEIGYK2hMJWVFYUQqB
0wKTOGTn8S64Dz+kmg9nt39UXfCdGruP0tWGnuQ4d4xdDAldhQoxIwWihBM/qo+p
bq+Nr3MT3JZu/kjPNE9M6SJ2a9CAprzHSxXOzsJaFOqJYPN6ApSNdqRflxv5oKml
o92mditHT8NgIwls4hqdLlDvdTKI7vqs6PoP3uOmniZBe1tEUev45Lc8WXgDRDzR
brMvKkOIrNATYbsuh1EFSQ8Xvb5F1nV6b2Wn0ksdDuFrq7J1+vRIINt4j1hYCmOT
Xyq9CUqIGlNPfQy/vK6eKLVMihJIBGwElSYh+62otrK5MQ70FoTPgQQijOK9U+V4
kOWLuwuOjCVxaompM2U7D6zEsh7/fjwMLVU1NtC7v86+sTD7BU17p5H5ATN9Zmpg
zOyF7eRBEhjs+SySdbHLWa0h59oTt05g/ygVJJpm9iZVkmUh1Rwn594D9JX4AP2m
ERZ+GKn4+X/ykiIWEbsaoWdOBq+PrD70RguMwiCFFFyYHG1qcH/bCQTGxX22KA7W
W4R3mmMfpjx5+lRKjxCPchaTBOvYzlydyeLZNoYnhHIaXLHSlrb5JrITgTI6y97i
zbbV8MWi3AenawciC24F
=dwLD
-----END PGP SIGNATURE-----

--rwSwrS9OkH+FvIfA--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/