MIME-Version: 1.0
In-Reply-To: <20151108065145.GA1183@alpha.sfu-kras.ru>
References: <20151108065145.GA1183@alpha.sfu-kras.ru>
Date: Sun, 8 Nov 2015 22:16:21 +0200
Message-ID: <CAHp75Vci+xZBZiZwLKErtgjbJP9+rRziUEQ6O=pb1wsN9FJSzQ@mail.gmail.com>
Subject: Re: [PATCH 10/12] staging: rtl8188eu: reg_macid variable removed in hw_var_set_macaddr
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Ivan Safonov <insafonov@gmail.com>
Cc: devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Vaishali Thakkar <vthakkar1994@gmail.com>,
        Jakub Sitnicki <jsitnicki@gmail.com>, Anish Bhatt <anish@gatech.edu>,
        Joe Perches <joe@perches.com>, Nicholas Mc Guire <der.herr@hofr.at>,
        Alexey Khoroshilov <khoroshilov@ispras.ru>,
        =?UTF-8?Q?R=C3=A9my_Oudompheng?= <remyoudompheng@gmail.com>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Shraddha Barke <shraddha.6596@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1829
Lines: 54

On Sun, Nov 8, 2015 at 8:51 AM, Ivan Safonov <insafonov@gmail.com> wrote:
> The reg_macid variable used only once. Also idx renamed to i and Adapter to adapter.
>
> Signed-off-by: Ivan Safonov <insafonov@gmail.com>
> ---
>  drivers/staging/rtl8188eu/hal/usb_halinit.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> index 5789e1e..e1d6632 100644
> --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> @@ -1253,15 +1253,12 @@ static void hw_var_set_opmode(struct adapter *Adapter, u8 variable, u8 *val)
>         }
>  }
>
> -static void hw_var_set_macaddr(struct adapter *Adapter, u8 variable, u8 *val)
> +static void hw_var_set_macaddr(struct adapter *adapter, u8 variable, u8 *val)
>  {
> -       u8 idx = 0;
> -       u32 reg_macid;
> -
> -       reg_macid = REG_MACID;
> +       int i;
>
> -       for (idx = 0; idx < 6; idx++)
> -               usb_write8(Adapter, (reg_macid+idx), val[idx]);
> +       for (i = 0; i < 6; i++)

ETH_ALEN?

> +               usb_write8(adapter, REG_MACID + i, val[i]);
>  }
>
>  static void hw_var_set_bssid(struct adapter *Adapter, u8 variable, u8 *val)
> --
> 2.4.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/