MIME-Version: 1.0
In-Reply-To: <563F315B.2020609@gmail.com>
References: <20151108063725.GA1073@alpha.sfu-kras.ru>
	<CAHp75VdT3eiEeZWWkA6bVP8ABPhypLRUPkcdu8ThE5kBPeK2JA@mail.gmail.com>
	<563F315B.2020609@gmail.com>
Date: Sun, 8 Nov 2015 22:24:52 +0200
Message-ID: <CAHp75VcbJpQSbC8Gjzp-YW0MBYVXVUZiv=H0fX+0=usAD4wGQQ@mail.gmail.com>
Subject: Re: [PATCH 02/12] staging: rtl8188eu: return value and argument types
 changed in _rtl88e_write_fw function
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Ivan Safonov <insafonov@gmail.com>
Cc: devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Vaishali Thakkar <vthakkar1994@gmail.com>,
        Jakub Sitnicki <jsitnicki@gmail.com>, Anish Bhatt <anish@gatech.edu>,
        Joe Perches <joe@perches.com>, Nicholas Mc Guire <der.herr@hofr.at>,
        Alexey Khoroshilov <khoroshilov@ispras.ru>,
        =?UTF-8?Q?R=C3=A9my_Oudompheng?= <remyoudompheng@gmail.com>,
        Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
        Shraddha Barke <shraddha.6596@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1463
Lines: 45

On Sun, Nov 8, 2015 at 1:26 PM, Ivan Safonov <insafonov@gmail.com> wrote:
> On 11/08/2015 05:11 PM, Andy Shevchenko wrote:
>>
>> On Sun, Nov 8, 2015 at 8:37 AM, Ivan Safonov <insafonov@gmail.com> wrote:
>>>
>>> Ideally the function should not change the variables outside of its body.

>>> -static void _rtl88e_fill_dummy(u8 *pfwbuf, u32 *pfwlen)
>>> +static u32 _rtl88e_fill_dummy(u8 *pfwbuf, u32 pfwlen)
>>>   {
>>>          u32 i;
>>>
>>> -       for (i = *pfwlen; i < roundup(*pfwlen, 4); i++)
>>> +       for (i = pfwlen; i < roundup(pfwlen, 4); i++)
>>>                  pfwbuf[i] = 0;
>>
>> memset() ?
>>
>>> -       *pfwlen = i;
>>> +       return i;
>>>   }
>>>
>>>   static void _rtl88e_fw_page_write(struct adapter *adapt,
>>> @@ -103,7 +103,7 @@ static void _rtl88e_write_fw(struct adapter *adapt,
>>> u8 *buffer, u32 size)
>>>          u32 page_no, remain;
>>>          u32 page, offset;
>>>
>>> -       _rtl88e_fill_dummy(buf_ptr, &size);
>>> +       size = _rtl88e_fill_dummy(buf_ptr, size);


> memset applied in another patch. Here only replacement of the function type.

Since it's used only once it would be nice to replace it by plain
memset() in one patch.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/