MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.10.1511080843100.2637@hadrien>
References: <alpine.DEB.2.10.1511080843100.2637@hadrien>
Date: Sun, 8 Nov 2015 23:15:32 +0200
Message-ID: <CAHp75VdRN14EWUaTPzO45Z_mBzeQ=9sqzP3mMsMSQ2nXNi5QKg@mail.gmail.com>
Subject: Re: [PATCH] dma: fix returnvar.cocci warnings
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Sinan Kaya <okaya@codeaurora.org>, Andy Gross <agross@codeaurora.org>,
        kbuild-all@01.org, dmaengine <dmaengine@vger.kernel.org>,
        timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com,
        linux-arm-msm@vger.kernel.org,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, Vinod Koul <vinod.koul@intel.com>,
        Dan Williams <dan.j.williams@intel.com>,
        devicetree <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2149
Lines: 67

On Sun, Nov 8, 2015 at 9:45 AM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>  Remove unneeded variable used to store return value.
>
> Generated by: scripts/coccinelle/misc/returnvar.cocci
>
> CC: Sinan Kaya <okaya@codeaurora.org>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Who is the author?
I suppose Fengguang is the reporter, right?

> ---
>
>  hidma_ll.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> --- a/drivers/dma/qcom/hidma_ll.c
> +++ b/drivers/dma/qcom/hidma_ll.c
> @@ -567,14 +567,13 @@ int hidma_ll_resume(struct hidma_lldev *
>
>  static int hidma_ll_hw_start(struct hidma_lldev *lldev)
>  {
> -       int rc = 0;
>         unsigned long irqflags;
>
>         spin_lock_irqsave(&lldev->lock, irqflags);
>         writel(lldev->tre_write_offset, lldev->trca + TRCA_DOORBELL_OFFSET);
>         spin_unlock_irqrestore(&lldev->lock, irqflags);
>
> -       return rc;
> +       return 0;
>  }
>
>  bool hidma_ll_isenabled(struct hidma_lldev *lldev)
> @@ -600,7 +599,6 @@ bool hidma_ll_isenabled(struct hidma_lld
>  int hidma_ll_queue_request(struct hidma_lldev *lldev, u32 tre_ch)
>  {
>         struct hidma_tre *tre;
> -       int rc = 0;
>         unsigned long flags;
>
>         tre = &lldev->trepool[tre_ch];
> @@ -618,7 +616,7 @@ int hidma_ll_queue_request(struct hidma_
>         lldev->tre_write_offset = (lldev->tre_write_offset + TRE_SIZE)
>                                 % lldev->tre_ring_size;
>         spin_unlock_irqrestore(&lldev->lock, flags);
> -       return rc;
> +       return 0;
>  }
>
>  int hidma_ll_start(struct hidma_lldev *lldev)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/