Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752239AbbKHVRx (ORCPT ); Sun, 8 Nov 2015 16:17:53 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:63378 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751349AbbKHVRv (ORCPT ); Sun, 8 Nov 2015 16:17:51 -0500 X-IronPort-AV: E=Sophos;i="5.20,263,1444687200"; d="scan'208";a="186634395" Date: Sun, 8 Nov 2015 21:17:46 +0000 (GMT) From: Julia Lawall X-X-Sender: jll@hadrien To: Andy Shevchenko cc: Julia Lawall , Sinan Kaya , Andy Gross , kbuild-all@01.org, dmaengine , timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, linux-arm-msm@vger.kernel.org, linux-arm Mailing List , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Vinod Koul , Dan Williams , devicetree , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] dma: fix returnvar.cocci warnings In-Reply-To: Message-ID: References: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2401 Lines: 79 On Sun, 8 Nov 2015, Andy Shevchenko wrote: > On Sun, Nov 8, 2015 at 9:45 AM, Julia Lawall wrote: > > Remove unneeded variable used to store return value. > > > > Generated by: scripts/coccinelle/misc/returnvar.cocci > > > > CC: Sinan Kaya > > Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall Sorry for the oversight. julia > > Who is the author? > I suppose Fengguang is the reporter, right? > > > --- > > > > hidma_ll.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > --- a/drivers/dma/qcom/hidma_ll.c > > +++ b/drivers/dma/qcom/hidma_ll.c > > @@ -567,14 +567,13 @@ int hidma_ll_resume(struct hidma_lldev * > > > > static int hidma_ll_hw_start(struct hidma_lldev *lldev) > > { > > - int rc = 0; > > unsigned long irqflags; > > > > spin_lock_irqsave(&lldev->lock, irqflags); > > writel(lldev->tre_write_offset, lldev->trca + TRCA_DOORBELL_OFFSET); > > spin_unlock_irqrestore(&lldev->lock, irqflags); > > > > - return rc; > > + return 0; > > } > > > > bool hidma_ll_isenabled(struct hidma_lldev *lldev) > > @@ -600,7 +599,6 @@ bool hidma_ll_isenabled(struct hidma_lld > > int hidma_ll_queue_request(struct hidma_lldev *lldev, u32 tre_ch) > > { > > struct hidma_tre *tre; > > - int rc = 0; > > unsigned long flags; > > > > tre = &lldev->trepool[tre_ch]; > > @@ -618,7 +616,7 @@ int hidma_ll_queue_request(struct hidma_ > > lldev->tre_write_offset = (lldev->tre_write_offset + TRE_SIZE) > > % lldev->tre_ring_size; > > spin_unlock_irqrestore(&lldev->lock, flags); > > - return rc; > > + return 0; > > } > > > > int hidma_ll_start(struct hidma_lldev *lldev) > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > > > -- > With Best Regards, > Andy Shevchenko > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/