Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751840AbbKHW5c (ORCPT ); Sun, 8 Nov 2015 17:57:32 -0500 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:42618 "EHLO e23smtp06.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbbKHW5a (ORCPT ); Sun, 8 Nov 2015 17:57:30 -0500 X-Helo: d23dlp03.au.ibm.com X-MailFrom: andrew.donnellan@au1.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Message-ID: <563FD31B.3090807@au1.ibm.com> Date: Mon, 09 Nov 2015 09:56:27 +1100 From: Andrew Donnellan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: SF Markus Elfring , Ian Munsie , Michael Neuling , linuxppc-dev@lists.ozlabs.org CC: Julia Lawall , kernel-janitors@vger.kernel.org, LKML Subject: Re: [PATCH] cxl: Delete an unnecessary check before the function call "kfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <563C7B7A.2080403@users.sourceforge.net> In-Reply-To: <563C7B7A.2080403@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15110822-0021-0000-0000-0000021DC318 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 956 Lines: 25 On 06/11/15 21:05, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 6 Nov 2015 11:00:23 +0100 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Thanks for picking this up - will remember in my future patches. Reviewed-by: Andrew Donnellan -- Andrew Donnellan Software Engineer, OzLabs andrew.donnellan@au1.ibm.com Australia Development Lab, Canberra +61 2 6201 8874 (work) IBM Australia Limited -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/