Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751922AbbKHXx0 (ORCPT ); Sun, 8 Nov 2015 18:53:26 -0500 Received: from mail-io0-f171.google.com ([209.85.223.171]:36650 "EHLO mail-io0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751348AbbKHXxY (ORCPT ); Sun, 8 Nov 2015 18:53:24 -0500 MIME-Version: 1.0 In-Reply-To: <20151104123008.GA15302@sophia> References: <20151104123008.GA15302@sophia> From: Alexandre Courbot Date: Mon, 9 Nov 2015 08:53:04 +0900 Message-ID: Subject: Re: [PATCH] gpio: 104-idio-16: Use lowercase symbol names for const variables To: William Breathitt Gray Cc: Linus Walleij , "linux-gpio@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 759 Lines: 18 On Wed, Nov 4, 2015 at 9:30 PM, William Breathitt Gray wrote: > To prevent confusion and to match existing coding style used in other > gpio drivers symbol names within the 104-idio-16 gpio driver should be > lowercase. ... and for the same styling reasons "GPIO" should be spelled in uppercase in your commit message. ;) Apart from that this patch seems harmless and the repositioning of some constant declarations is also welcome. Reviewed-by: Alexandre Courbot -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/