Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752462AbbKICC3 (ORCPT ); Sun, 8 Nov 2015 21:02:29 -0500 Received: from mail-yk0-f176.google.com ([209.85.160.176]:34148 "EHLO mail-yk0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752062AbbKICC1 (ORCPT ); Sun, 8 Nov 2015 21:02:27 -0500 MIME-Version: 1.0 In-Reply-To: <20151106165644.GA23834@kroah.com> References: <20151106165644.GA23834@kroah.com> Date: Mon, 9 Nov 2015 10:02:27 +0800 Message-ID: Subject: Re: [PATCH v5 1/5] gadget: Introduce the notifier functions From: Baolin Wang To: Greg KH Cc: Felipe Balbi , sre@kernel.org, Dmitry Eremin-Solenikov , David Woodhouse , Mark Brown , LKML , Peter Chen , Alan Stern , r.baldyga@samsung.com, yoshihiro.shimoda.uh@renesas.com, linux-usb@vger.kernel.org, device-mainlining@lists.linuxfoundation.org, sameo@linux.intel.com, Lee Jones , ckeepax@opensource.wolfsonmicro.com, patches@opensource.wolfsonmicro.com, linux-pm@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1659 Lines: 58 On 7 November 2015 at 00:56, Greg KH wrote: > On Fri, Nov 06, 2015 at 07:35:10PM +0800, Baolin Wang wrote: >> #ifdef CONFIG_HAS_DMA >> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h >> index c14a69b..755e8bc 100644 >> --- a/include/linux/usb/gadget.h >> +++ b/include/linux/usb/gadget.h >> @@ -609,6 +609,8 @@ struct usb_gadget { >> unsigned out_epnum; >> unsigned in_epnum; >> struct usb_otg_caps *otg_caps; >> + struct raw_notifier_head nh; >> + struct mutex lock; > > You have to document what this lock protects. OK. > > >> >> unsigned sg_supported:1; >> unsigned is_otg:1; >> @@ -1183,6 +1185,22 @@ extern void usb_gadget_unmap_request(struct usb_gadget *gadget, >> >> /*-------------------------------------------------------------------------*/ >> >> +/** >> + * Register a notifiee to get notified by any attach status changes from >> + * the usb gadget >> + */ > > kerneldoc does not belong in a .h file. > I'll remove the comments. > And the kbuild system found lots of problems with this series, please > fix those at the very least :( I'm sorry for that, I'll check the patches again. Thanks for your comments. > > thanks, > > greg k-h -- Baolin.wang Best Regards -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/